[Multiple Datasource] Add component to show single selected data source in read only mode #6125

BionIT · 2024-03-12T22:43:17Z

Description

This change adds component to show single selected data source in read only mode

Issues Resolved

Screenshot

readonlysingle.mp4

Testing the changes

The following were performed in the recording:

enable data source plugin, and see the mounted single selected data source component
when clicking on the info icon, a drop down shows which displays the currently used data source
disable data source plugin, and we should not see the mounted single selected data source component

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: Lu Yu <nluyu@amazon.com>

Flyingliuhub · 2024-03-12T22:52:23Z

@BionIT can we add the changelog? Thanks

codecov · 2024-03-12T22:57:45Z

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 67.15%. Comparing base (45096bb) to head (5905527).

Files	Patch %	Lines
...c/components/data_source_view/data_source_view.tsx	61.53%	2 Missing and 3 partials ⚠️
...c/components/data_source_menu/data_source_menu.tsx	57.14%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6125      +/-   ##
==========================================
- Coverage   67.15%   67.15%   -0.01%     
==========================================
  Files        3326     3327       +1     
  Lines       64400    64415      +15     
  Branches    10361    10366       +5     
==========================================
+ Hits        43251    43260       +9     
- Misses      18619    18622       +3     
- Partials     2530     2533       +3

Flag	Coverage Δ
Linux_1	`31.73% <ø> (ø)`
Linux_2	`55.23% <ø> (ø)`
Linux_3	`44.75% <60.00%> (-0.01%)`	⬇️
Linux_4	`35.06% <0.00%> (-0.02%)`	⬇️
Windows_1	`31.75% <ø> (ø)`
Windows_2	`55.20% <ø> (ø)`
Windows_3	`44.77% <60.00%> (+0.01%)`	⬆️
Windows_4	`35.06% <0.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BionIT · 2024-03-12T23:04:25Z

@BionIT can we add the changelog? Thanks

yeah, the change log has been added!

src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx

Flyingliuhub · 2024-03-12T23:22:26Z

src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx

+          iconType="database"
+          iconSide="left"
+          size="s"
+          disabled={true}


should we have some condition here to dynamically compute the value of disabled? like as somethingthis.props.selectedOption ? Thanks

This is always disabled based on requirements, since this component is only used in readyonly mode

xinruiba · 2024-03-12T23:25:10Z

src/plugins/data_source_management/public/components/data_source_menu/data_source_menu.tsx

-  hideLocalCluster: boolean;
-  dataSourceCallBackFunc: (dataSource: DataSourceOption) => void;
+  hideLocalCluster?: boolean;
+  dataSourceCallBackFunc?: (dataSource: DataSourceOption) => void;


Since we do "!" operation here: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6125/files#diff-ca572b8e5224968b4b5cfd2a810b1280195b20f6eff17b93657fefa89bb50ed1R75

Any reason we set these props as optional?

the callback function doesn't make sense for read only component, since there is no change to the selection, but only makes sense for selectables, hope it makes sense

Thanks for the response.

In that case I assume we don't need this line?:
https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6125/files#diff-ca572b8e5224968b4b5cfd2a810b1280195b20f6eff17b93657fefa89bb50ed1R91

Signed-off-by: Lu Yu <nluyu@amazon.com>

…ce in read only mode (#6125) * add component to show selected data source in read only mode Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> * fix typo and remove unused fields Signed-off-by: Lu Yu <nluyu@amazon.com> * fix snapshot Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit df6de4e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

…ce in read only mode (#6125) (#6262) * add component to show selected data source in read only mode Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> * fix typo and remove unused fields Signed-off-by: Lu Yu <nluyu@amazon.com> * fix snapshot Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit df6de4e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

add component to show selected data source in read only mode

1d0b584

Signed-off-by: Lu Yu <nluyu@amazon.com>

BionIT requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, BSFishy, curq, bandinib-amzn, SuZhou-Joe and ruanyl as code owners March 12, 2024 22:43

github-actions bot added the seasoned-contributor label Mar 12, 2024

add change log

6b92ced

Signed-off-by: Lu Yu <nluyu@amazon.com>

yujin-emma approved these changes Mar 12, 2024

View reviewed changes

Flyingliuhub reviewed Mar 12, 2024

View reviewed changes

src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx Outdated Show resolved Hide resolved

Flyingliuhub reviewed Mar 12, 2024

View reviewed changes

src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx Outdated Show resolved Hide resolved

Flyingliuhub reviewed Mar 12, 2024

View reviewed changes

xinruiba reviewed Mar 12, 2024

View reviewed changes

BionIT added 2 commits March 12, 2024 23:54

fix typo and remove unused fields

800b65f

Signed-off-by: Lu Yu <nluyu@amazon.com>

fix snapshot

5905527

Signed-off-by: Lu Yu <nluyu@amazon.com>

ZilongX previously approved these changes Mar 12, 2024

View reviewed changes

BionIT dismissed ZilongX’s stale review via 5905527 March 12, 2024 23:58

xinruiba approved these changes Mar 13, 2024

View reviewed changes

Flyingliuhub approved these changes Mar 13, 2024

View reviewed changes

ZilongX self-requested a review March 13, 2024 02:59

ZilongX approved these changes Mar 13, 2024

View reviewed changes

BionIT merged commit df6de4e into opensearch-project:main Mar 13, 2024
66 of 69 checks passed

BionIT added v2.14.0 multiple datasource multiple datasource project labels Mar 13, 2024

This was referenced Mar 19, 2024

[Meta] [2.14] Security, bug fix and enhancemanet for dashboards anywhere #5872

Closed

[Meta][UX][Multiple Datasource] Improvement to data source components in the navigation bar #6216

Closed

BionIT added the backport 2.x label Mar 25, 2024

opensearch-trigger-bot bot mentioned this pull request Mar 25, 2024

[Backport 2.x] [Multiple Datasource] Add component to show single selected data source in read only mode #6262

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Multiple Datasource] Add component to show single selected data source in read only mode #6125

[Multiple Datasource] Add component to show single selected data source in read only mode #6125

BionIT commented Mar 12, 2024

Flyingliuhub commented Mar 12, 2024

codecov bot commented Mar 12, 2024 •

edited

Loading

BionIT commented Mar 12, 2024

Flyingliuhub Mar 12, 2024

BionIT Mar 12, 2024

xinruiba Mar 12, 2024 •

edited

Loading

BionIT Mar 12, 2024

xinruiba Mar 13, 2024 •

edited

Loading

[Multiple Datasource] Add component to show single selected data source in read only mode #6125

[Multiple Datasource] Add component to show single selected data source in read only mode #6125

Conversation

BionIT commented Mar 12, 2024

Description

Issues Resolved

Screenshot

Testing the changes

Check List

Flyingliuhub commented Mar 12, 2024

codecov bot commented Mar 12, 2024 • edited Loading

Codecov Report

BionIT commented Mar 12, 2024

Flyingliuhub Mar 12, 2024

Choose a reason for hiding this comment

BionIT Mar 12, 2024

Choose a reason for hiding this comment

xinruiba Mar 12, 2024 • edited Loading

Choose a reason for hiding this comment

BionIT Mar 12, 2024

Choose a reason for hiding this comment

xinruiba Mar 13, 2024 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Mar 12, 2024 •

edited

Loading

xinruiba Mar 12, 2024 •

edited

Loading

xinruiba Mar 13, 2024 •

edited

Loading