-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass request headers when making application config calls #6164
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6164 +/- ##
==========================================
+ Coverage 67.21% 67.24% +0.02%
==========================================
Files 3344 3344
Lines 64792 64796 +4
Branches 10427 10427
==========================================
+ Hits 43552 43572 +20
+ Misses 18697 18683 -14
+ Partials 2543 2541 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
93dcf8a
to
34703ce
Compare
The failed test https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/8331507596/job/22798565980?pr=6164 is not related to my changes. |
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cypress test likely to fail unrelated
Re-running failed CI |
Application config plugin allows external plugin to register a different storage other than the default OpenSearch. The external plugin may need some additional information about the request headers when handling the requests. * Allow extra information in the application config calls Signed-off-by: Tianle Huang <tianleh@amazon.com> * only expose headers Signed-off-by: Tianle Huang <tianleh@amazon.com> * update jsdoc Signed-off-by: Tianle Huang <tianleh@amazon.com> * add more logs Signed-off-by: Tianle Huang <tianleh@amazon.com> * update change log Signed-off-by: Tianle Huang <tianleh@amazon.com> * update readme Signed-off-by: Tianle Huang <tianleh@amazon.com> * update readme Signed-off-by: Tianle Huang <tianleh@amazon.com> --------- Signed-off-by: Tianle Huang <tianleh@amazon.com> (cherry picked from commit bfab07c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
) Application config plugin allows external plugin to register a different storage other than the default OpenSearch. The external plugin may need some additional information about the request headers when handling the requests. * Allow extra information in the application config calls Signed-off-by: Tianle Huang <tianleh@amazon.com> * only expose headers Signed-off-by: Tianle Huang <tianleh@amazon.com> * update jsdoc Signed-off-by: Tianle Huang <tianleh@amazon.com> * add more logs Signed-off-by: Tianle Huang <tianleh@amazon.com> * update change log Signed-off-by: Tianle Huang <tianleh@amazon.com> * update readme Signed-off-by: Tianle Huang <tianleh@amazon.com> * update readme Signed-off-by: Tianle Huang <tianleh@amazon.com> --------- Signed-off-by: Tianle Huang <tianleh@amazon.com> (cherry picked from commit bfab07c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Application config plugin allows external plugin to register a different storage other than the default OpenSearch. The external plugin may need some additional information about the request headers when handling the requests.
Issues Resolved
Screenshot
Testing the changes
Update the csp rules.
call
response
Confirm on UI that the new value is used.
Check API calls to all configs
curl 'http://localhost:5601/api/appconfig'
response
Check API to get only csp rules.
response
Delete
Response
Get all again
response
verify that default csp with frame ancestors is used.
Check List
yarn test:jest
yarn test:jest_integration