Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix obsolete snapshots for test within data source management plugin #6185

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

BionIT
Copy link
Collaborator

@BionIT BionIT commented Mar 18, 2024

Description

This change removes obsolete snapshots to fix the test under data source management plugin

Issues Resolved

Screenshot

Testing the changes

The obsolete snapshots from the tests were removed by executing yarn test:jest -u src/plugins/data_source_management/ and the following is the output

Snapshot Summary
 › 2 snapshots removed from 1 test suite.
   ↳ src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.test.tsx
       • DataSourceAggregatedView should render normally with local cluster and actice selections 2
       • DataSourceAggregatedView should render normally with local cluster and actice selections 3

Test Suites: 22 passed, 22 total
Tests:       133 passed, 133 total
Snapshots:   2 removed, 38 passed, 38 total
Time:        15.354 s
Ran all test suites matching /src\/plugins\/data_source_management\//i.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
@@ -62,6 +62,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [BUG][Multiple Datasource] Add a migration function for datasource to add migrationVersion field ([#6025](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6025))
- [BUG][MD]Expose picker using function in data source management plugin setup([#6030](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6030))
- [BUG][Multiple Datasource] Fix data source filter bug and add tests ([#6152](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6152))
- [BUG][Multiple Datasource] Fix obsolete snapshots for test within data source management plugin ([#6185](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6185))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We dont need a changelog entry when the fix happens in the same release as the feature since the bug isnt visible yet

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Thanks for pointing that out!

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.25%. Comparing base (05abf5e) to head (496df2e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6185      +/-   ##
==========================================
+ Coverage   67.23%   67.25%   +0.01%     
==========================================
  Files        3344     3344              
  Lines       64792    64792              
  Branches    10427    10427              
==========================================
+ Hits        43566    43578      +12     
+ Misses      18684    18672      -12     
  Partials     2542     2542              
Flag Coverage Δ
Linux_1 31.64% <ø> (ø)
Linux_2 55.45% <ø> (ø)
Linux_3 44.69% <ø> (?)
Linux_4 35.06% <ø> (ø)
Windows_1 31.69% <ø> (+0.02%) ⬆️
Windows_2 55.41% <ø> (ø)
Windows_3 44.69% <ø> (ø)
Windows_4 35.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bandinib-amzn bandinib-amzn self-requested a review March 18, 2024 21:22
@BionIT BionIT merged commit a9e874f into opensearch-project:main Mar 18, 2024
70 checks passed
@BionIT BionIT added the multiple datasource multiple datasource project label Mar 18, 2024
@BionIT BionIT added the v2.14.0 label Mar 18, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 25, 2024
…lugin (#6185)

* remove obsolete snapshots

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add change log

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
(cherry picked from commit a9e874f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
BionIT pushed a commit that referenced this pull request Mar 26, 2024
…lugin (#6185) (#6266)

* remove obsolete snapshots

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add change log

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
(cherry picked from commit a9e874f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants