-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix web log sample visualization & vis-builder not rendering with data source issue #6948
Fix web log sample visualization & vis-builder not rendering with data source issue #6948
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6948 +/- ##
==========================================
- Coverage 67.45% 67.43% -0.02%
==========================================
Files 3443 3443
Lines 67815 67815
Branches 11033 11033
==========================================
- Hits 45742 45730 -12
- Misses 19406 19418 +12
Partials 2667 2667
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
ffbf237
to
647b572
Compare
@@ -398,7 +398,7 @@ export const getSavedObjects = (): SavedObject[] => [ | |||
description: '', | |||
kibanaSavedObjectMeta: { | |||
searchSourceJSON: | |||
'{"query":{"query":"","language":"kuery"},"filter":[],"indexRefName":"kibanaSavedObjectMeta.searchSourceJSON.index"}', | |||
'{"index":"90943e30-9a47-11e8-b64d-95841ca0b247","query":{"query":"","language":"kuery"},"filter":[]}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we change from indexRefName":"kibanaSavedObjectMeta.searchSourceJSON.index to doc id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so if you check the other sample visualizations that are working fine, they all following same pattern
- define "index" in "searchSourceJson"
- define "references" field as empty array.
But visualizations in this file are not following the pattern, that's why only them will fail our logic to add reference to data source, and fail to render with data source.
OpenSearch-Dashboards/src/plugins/home/server/services/sample_data/data_sets/util.ts
Line 43 in 58d49ca
if (searchSource.index) { |
src/plugins/home/server/services/sample_data/data_sets/logs/saved_objects.ts
Show resolved
Hide resolved
…a source issue (#6948) * Fix web log sample visualization & visbuilder not rendering issue Signed-off-by: Zhongnan Su <szhongna@amazon.com> * Changeset file for PR #6948 created/updated --------- Signed-off-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 9a6b1bb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…a source issue (#6948) (#6958) * Fix web log sample visualization & visbuilder not rendering issue * Changeset file for PR #6948 created/updated --------- (cherry picked from commit 9a6b1bb) Signed-off-by: Zhongnan Su <szhongna@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Currently visual consistency sample dashboard is failing, see future playground
This PR fixes the issue by
Issues Resolved
#6857
#6938
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration