Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some files and add advanced settings #6973

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"server": true,
"ui": true,
"requiredPlugins": ["data"],
"optionalPlugins": ["home"],
"optionalPlugins": [],
"requiredBundles": ["opensearchDashboardsUtils", "opensearchDashboardsReact"]
}
2 changes: 0 additions & 2 deletions plugins-extra/query_enhancements/public/types.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { DataPublicPluginSetup, DataPublicPluginStart } from 'src/plugins/data/public';
import { NavigationPublicPluginStart } from '../../../src/plugins/navigation/public';

// eslint-disable-next-line @typescript-eslint/no-empty-interface
export interface QueryEnhancementsPluginSetup {}
Expand All @@ -12,6 +11,5 @@ export interface QueryEnhancementsPluginSetupDependencies {
}

export interface QueryEnhancementsPluginStartDependencies {
navigation: NavigationPublicPluginStart;
data: DataPublicPluginStart;
}
8 changes: 4 additions & 4 deletions plugins-extra/query_enhancements/server/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ import { PPL_SEARCH_STRATEGY, SQL_SEARCH_STRATEGY, SQL_ASYNC_SEARCH_STRATEGY } f
import { pplSearchStrategyProvider } from './search/ppl/ppl_search_strategy';
import { sqlSearchStrategyProvider } from './search/sql/sql_search_strategy';
import { sqlAsyncSearchStrategyProvider } from './search/sql/sql_async_search_strategy';

// import { logsPPLSpecProvider } from './sample_data/ppl';
// const pplSampleDateSet = logsPPLSpecProvider();
import { uiSettings } from './ui_settings';

export class QueryEnhancementsPlugin
implements Plugin<QueryEnhancementsPluginSetup, QueryEnhancementsPluginStart> {
Expand All @@ -33,14 +31,16 @@ export class QueryEnhancementsPlugin
this.config$ = initializerContext.config.legacy.globalConfig$;
}

public setup(core: CoreSetup, { data, home }: QueryEnhancementsPluginSetupDependencies) {
public setup(core: CoreSetup, { data }: QueryEnhancementsPluginSetupDependencies) {
this.logger.debug('queryEnhancements: Setup');
const router = core.http.createRouter();
// Register server side APIs
const client = core.opensearch.legacy.createClient('opensearch_observability', {
plugins: [PPLPlugin, EnginePlugin],
});

core.uiSettings.register(uiSettings);

const pplSearchStrategy = pplSearchStrategyProvider(this.config$, this.logger, client);
const sqlSearchStrategy = sqlSearchStrategyProvider(this.config$, this.logger, client);
const sqlAsyncSearchStrategy = sqlAsyncSearchStrategyProvider(
Expand Down

This file was deleted.

59 changes: 0 additions & 59 deletions plugins-extra/query_enhancements/server/sample_data/ppl/index.ts

This file was deleted.

Binary file not shown.
Loading
Loading