-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Refactor the UI of workspace picker #7045
[Workspace] Refactor the UI of workspace picker #7045
Conversation
Signed-off-by: yubonluo <yubonluo@amazon.com>
…oards into 2.16-refactor-workspace-picker
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7045 +/- ##
==========================================
+ Coverage 67.67% 67.69% +0.01%
==========================================
Files 3516 3517 +1
Lines 69544 69567 +23
Branches 11349 11351 +2
==========================================
+ Hits 47067 47093 +26
+ Misses 19692 19689 -3
Partials 2785 2785
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <yubonluo@amazon.com>
…OpenSearch-Dashboards into 2.16-refactor-workspace-picker
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
src/plugins/workspace/public/components/workspace_menu/workspace_menu.scss
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
…oards into 2.16-refactor-workspace-picker
1b78b64
to
16ab467
Compare
Signed-off-by: yubonluo <yubonluo@amazon.com>
16ab467
to
125b43e
Compare
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7045-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7f9bdd739ea4a90e161e1efd512b053872d8b6c2
# Push it to GitHub
git push --set-upstream origin backport/backport-7045-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
@yubonluo the auto backport is failed, you may need a manual backport |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7045-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7f9bdd739ea4a90e161e1efd512b053872d8b6c2
# Push it to GitHub
git push --set-upstream origin backport/backport-7045-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
This was successfully backported manually. |
Description
Refactor the UI of workspace picker. When workspace and new home page enabled, user can find the workspace menu button on the bottom of left navigation.
Issues Resolved
#7044
Screenshot
NewHomePage
is disabled, the workspace picker menu will not be shown.Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration