-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] kbn-config-schema to osd-config-scheme #71
[Rename] kbn-config-schema to osd-config-scheme #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !! Probably let's add this into doc for URLs follow http://opensearch-dashboards.local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
e9e3db3
to
11996c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
* [Rename] kbn-config-schema to osd-config-scheme Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Handle PR comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* [Rename] kbn-config-schema to osd-config-scheme Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Handle PR comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* [Rename] kbn-config-schema to osd-config-scheme Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Handle PR comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…ject#71) * feat: update public workspace Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * refractor: change public objects logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: create public workspace when service start Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some modify Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feature: some optimize and create workspace when ui settings is open Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * temp: submit Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update query dsl Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use same constants Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make it run Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove dashboard admin Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: list principals route Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change public logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove init Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add judgement when workspaceList is empty Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
…ject#71) * feat: update public workspace Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * refractor: change public objects logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: create public workspace when service start Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some modify Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feature: some optimize and create workspace when ui settings is open Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * temp: submit Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update query dsl Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use same constants Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make it run Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove dashboard admin Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: list principals route Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change public logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove init Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add judgement when workspaceList is empty Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
…ject#71) * feat: update public workspace Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * refractor: change public objects logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: create public workspace when service start Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some modify Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feature: some optimize and create workspace when ui settings is open Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * temp: submit Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update query dsl Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use same constants Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make it run Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove dashboard admin Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: modify query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: list principals route Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize query DSL Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change public logic Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove init Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add judgement when workspaceList is empty Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issue #, if available:
#37
Description of changes:
Rename folders, files, and variables within kbn-config-schema.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.