[Discover-next] (QueryEditorExtensions) change isEnabled to an observable #7183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
joshuali925
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7183 +/- ##
==========================================
+ Coverage 67.50% 67.56% +0.05%
==========================================
Files 3468 3469 +1
Lines 68402 68479 +77
Branches 11117 11130 +13
==========================================
+ Hits 46174 46266 +92
+ Misses 19532 19511 -21
- Partials 2696 2702 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joshuali925
added
the
Skip-Changelog
ashwin-pc
previously approved these changes
Jul 6, 2024
github-actions
bot
removed
the
Skip-Changelog
ashwin-pc
approved these changes
Jul 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
…able (#7183) * (QueryEditorExtensions) change isEnabled to an observable Signed-off-by: Joshua Li <joshuali925@gmail.com> * rename search bar extension to query editor extension in comments Signed-off-by: Joshua Li <joshuali925@gmail.com> * Changeset file for PR #7183 created/updated --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 774f64e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
added a commit
to kavilla/queryEnhancements
that referenced
this pull request
Jul 8, 2024
…nnection
previously query assist reads the datasource id from the selected index pattern. this PR updates it to read from the new `ConnectionsService`
- fix!: remove dataSource key in get connection response
- this is a breaking change on the return response of `GET ${API.DATA_SOURCE.CONNECTIONS}/{dataSourceId}` to be consistent with type
- change isEnabled to an observable based on selected connection
- this depends on opensearch-project/OpenSearch-Dashboards#7183, should go in with that PR
Signed-off-by: Joshua Li <joshuali925@gmail.com>
abbyhu2000
pushed a commit
that referenced
this pull request
Jul 22, 2024
…able (#7183) (#7193) * (QueryEditorExtensions) change isEnabled to an observable * rename search bar extension to query editor extension in comments * Changeset file for PR #7183 created/updated --------- (cherry picked from commit 774f64e) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ananzh
pushed a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Jul 24, 2024
…able (opensearch-project#7183) (opensearch-project#7193) * (QueryEditorExtensions) change isEnabled to an observable * rename search bar extension to query editor extension in comments * Changeset file for PR opensearch-project#7183 created/updated --------- (cherry picked from commit 774f64e) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Query Assist feature depends on QueryEditorExtensions and datasource connections service. The change to the currently selected connection will be exposed through an observable (ref), changing
isEnabledto an observable makes it easier to update when the selected connection changes.Issues Resolved
#7034 (comment)
Screenshot
Testing the changes
Changelog
isEnabledto an observableCheck List
yarn test:jestyarn test:jest_integration