fix(queryEnhancements): fix dataSource.id reference to enable tests #7272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <joshuali925@gmail.com>
joshuali925
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
7 tasks
github-actions
bot
added
the
Skip-Changelog
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7272 +/- ##
==========================================
+ Coverage 63.98% 64.03% +0.05%
==========================================
Files 3598 3598
Lines 78322 78322
Branches 12352 12352
==========================================
+ Hits 50111 50155 +44
+ Misses 25189 25139 -50
- Partials 3022 3028 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
i think test failure unrelated to this PR |
abbyhu2000
approved these changes
Jul 17, 2024
ananzh
pushed a commit
that referenced
this pull request
Jul 24, 2024
…7272) (#7406) (cherry picked from commit c8496f8) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
ananzh
pushed a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Jul 24, 2024
…pensearch-project#7272) (opensearch-project#7406) (cherry picked from commit c8496f8) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RequestHandlerContextas it's impacting other references in corecontext.query_assist.configPromiseto be an error on type level. not sure what's the best solutionIssues Resolved
#7212 (comment)
#7212 (comment)
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration