New Query Enhancement UI #7309

abbyhu2000 · 2024-07-18T21:30:26Z

Description

New query enhancement UI.

Issues Resolved

#7038

Screenshot

Screen.Recording.2024-07-18.at.2.35.01.PM.mov

Testing the changes

Changelog

feat: Update query enhancement UI

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2024-07-18T21:46:05Z

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.53%. Comparing base (6f28170) to head (7981a2e).
Report is 1 commits behind head on main.

Files	Patch %	Lines
.../data/public/ui/query_editor/language_selector.tsx	58.82%	6 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7309   +/-   ##
=======================================
  Coverage   67.53%   67.53%           
=======================================
  Files        3504     3504           
  Lines       69407    69418   +11     
  Branches    11324    11327    +3     
=======================================
+ Hits        46872    46881    +9     
- Misses      19775    19777    +2     
  Partials     2760     2760

Flag	Coverage Δ
Linux_1	`33.15% <ø> (ø)`
Linux_2	`55.46% <ø> (ø)`
Linux_3	`43.06% <58.82%> (+0.01%)`	⬆️
Linux_4	`34.76% <ø> (ø)`
Windows_1	`33.17% <ø> (ø)`
Windows_2	`55.41% <ø> (ø)`
Windows_3	`43.07% <58.82%> (+<0.01%)`	⬆️
Windows_4	`34.76% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abbyhu2000 · 2024-07-19T22:33:56Z

@ashwin-pc

fix the padding
changed footer to use OUI theme color
the default is not PPL, it is based on local storage
changed the language shadow box to use OUI theme color
based on discussion @kgcreative we agree to get rid of the arrow on the right of the saved query management

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

ashwin-pc

Nice, this gets the framework in. Since we have gone the custom route, lets clean up the styles to make the fit and finish better.

ashwin-pc · 2024-07-20T01:52:45Z

src/plugins/data/public/ui/query_editor/query_editor_extensions/query_editor_extension.tsx

@@ -61,7 +61,6 @@ export interface QueryEditorExtensionConfig {
 */
 getBanner?: (dependencies: QueryEditorExtensionDependencies) => React.ReactElement | null;
 }
-


nit: Think you might have unintentionally deleted this line

opensearch-trigger-bot · 2024-07-20T04:21:36Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7309-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f955faa37d78ffad09b6902da4a1f900d4616a94
# Push it to GitHub
git push --set-upstream origin backport/backport-7309-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7309-to-2.x.

opensearch-trigger-bot · 2024-07-23T00:06:05Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7309-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f955faa37d78ffad09b6902da4a1f900d4616a94
# Push it to GitHub
git push --set-upstream origin backport/backport-7309-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7309-to-2.x.

* UI changes Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * update snapshots Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * styling Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * correct license Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * more cleanup Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * more styling and update snapshots Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* UI changes * update snapshots * styling * correct license * more cleanup * more styling and update snapshots --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

…t#7457) * UI changes * update snapshots * styling * correct license * more cleanup * more styling and update snapshots --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

abbyhu2000 requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT, xinruiba, zhyuanqi, mengweieric, LDrago27 and virajsanghvi as code owners July 18, 2024 21:30

github-actions bot added distinguished-contributor failed changeset and removed failed changeset labels Jul 18, 2024

opensearch-changeset-bot bot added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Jul 18, 2024

Changeset file for PR opensearch-project#7309 created/updated

6ea67b0

kavilla previously approved these changes Jul 18, 2024

View reviewed changes

abbyhu2000 added v2.16.0 discover-next labels Jul 18, 2024

opensearch-project deleted a comment from github-actions bot Jul 18, 2024

abbyhu2000 dismissed kavilla’s stale review via 43b0e04 July 18, 2024 22:07

abbyhu2000 force-pushed the query_bar_4 branch from e0baac5 to fb6c9b9 Compare July 19, 2024 22:30

abbyhu2000 force-pushed the query_bar_4 branch 5 times, most recently from 21c1a35 to 6e6ff41 Compare July 19, 2024 23:18

UI changes

f57e585

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

abbyhu2000 force-pushed the query_bar_4 branch from 6e6ff41 to f57e585 Compare July 19, 2024 23:18

abbyhu2000 added 2 commits July 19, 2024 23:20

update snapshots

0ce0009

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

styling

63ee0b8

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

abbyhu2000 force-pushed the query_bar_4 branch from b563d75 to 63ee0b8 Compare July 19, 2024 23:30

abbyhu2000 added 3 commits July 19, 2024 23:31

correct license

8b7e6b0

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

more cleanup

c35e8a9

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

more styling and update snapshots

7981a2e

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

ashwin-pc approved these changes Jul 20, 2024

View reviewed changes

kavilla approved these changes Jul 20, 2024

View reviewed changes

ashwin-pc merged commit f955faa into opensearch-project:main Jul 20, 2024
66 of 67 checks passed

opensearch-trigger-bot bot added the failed backport label Jul 20, 2024

ashwin-pc mentioned this pull request Jul 22, 2024

[RELEASE] Release version 2.16.0 opensearch-project/opensearch-build#4771

Closed

74 tasks

abbyhu2000 added backport 2.x and removed backport 2.x labels Jul 23, 2024

abbyhu2000 mentioned this pull request Jul 24, 2024

[Manual backport 2.x] New Query Enhancement UI #7457

Merged

7 tasks

ananzh pushed a commit that referenced this pull request Jul 24, 2024

New Query Enhancement UI (#7309) (#7457)

8ee8678

* UI changes * update snapshots * styling * correct license * more cleanup * more styling and update snapshots --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

ananzh mentioned this pull request Jul 24, 2024

Missing backports from current 2.x to 2.16 #7466

Closed

7 tasks

AMoo-Miki removed the failed backport label Aug 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Query Enhancement UI #7309

New Query Enhancement UI #7309

abbyhu2000 commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading

abbyhu2000 commented Jul 19, 2024

ashwin-pc left a comment

ashwin-pc Jul 20, 2024

opensearch-trigger-bot bot commented Jul 20, 2024

opensearch-trigger-bot bot commented Jul 23, 2024

New Query Enhancement UI #7309

New Query Enhancement UI #7309

Conversation

abbyhu2000 commented Jul 18, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

codecov bot commented Jul 18, 2024 • edited Loading

Codecov Report

abbyhu2000 commented Jul 19, 2024

ashwin-pc left a comment

Choose a reason for hiding this comment

ashwin-pc Jul 20, 2024

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Jul 20, 2024

opensearch-trigger-bot bot commented Jul 23, 2024

abbyhu2000 commented Jul 18, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading