Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress data source selector on management's data sources page #7329

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Screen Shot 2024-07-19 at 17 59 51

I see a 2px height diff which is problem with the DataSourceSelector component.

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.70%. Comparing base (46afb96) to head (e236782).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7329      +/-   ##
==========================================
+ Coverage   67.68%   67.70%   +0.02%     
==========================================
  Files        3521     3521              
  Lines       69777    69777              
  Branches    11390    11390              
==========================================
+ Hits        47232    47246      +14     
+ Misses      19742    19730      -12     
+ Partials     2803     2801       -2     
Flag Coverage Δ
Linux_1 33.15% <ø> (ø)
Linux_2 55.46% <ø> (ø)
Linux_3 43.25% <ø> (?)
Linux_4 34.81% <ø> (-0.01%) ⬇️
Windows_1 33.17% <ø> (ø)
Windows_2 55.41% <ø> (?)
Windows_3 43.26% <ø> (ø)
Windows_4 34.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashwin-pc
ashwin-pc previously approved these changes Jul 21, 2024
@ruanyl
Copy link
Member

ruanyl commented Jul 21, 2024

@AMoo-Miki You may need to update the failed snapshot tests

* management's data sources page
* dev tools
* home
* query enhancements
* saved object mgmt
* time series

Signed-off-by: Miki <miki@amazon.com>
@virajsanghvi virajsanghvi added the look & feel Look and Feel Improvements label Jul 22, 2024
@AMoo-Miki AMoo-Miki merged commit 3526f96 into opensearch-project:main Jul 22, 2024
68 of 69 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7329-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3526f96f5889227fd79f3e671b3e3507a1a547d1
# Push it to GitHub
git push --set-upstream origin backport/backport-7329-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7329-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
* management's data sources page
* dev tools
* home
* query enhancements
* saved object mgmt
* time series

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3526f96)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
* management's data sources page
* dev tools
* home
* query enhancements
* saved object mgmt
* time series

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3526f96)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu pushed a commit that referenced this pull request Jul 24, 2024
* management's data sources page
* dev tools
* home
* query enhancements
* saved object mgmt
* time series



(cherry picked from commit 3526f96)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
…h-project#7412)

* management's data sources page
* dev tools
* home
* query enhancements
* saved object mgmt
* time series



(cherry picked from commit 3526f96)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.16 distinguished-contributor look & feel Look and Feel Improvements Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants