-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.16] Fix minor issues for Direct Query Datasource #7419
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.16 #7419 +/- ##
==========================================
- Coverage 67.87% 67.85% -0.02%
==========================================
Files 3589 3589
Lines 72327 72354 +27
Branches 11838 11844 +6
==========================================
+ Hits 49091 49095 +4
- Misses 20245 20265 +20
- Partials 2991 2994 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
5 similar comments
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
2 similar comments
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
...urces_components/direct_query_data_connection/manage_direct_query_data_connections_table.tsx
Outdated
Show resolved
Hide resolved
src/plugins/data_source_management/server/routes/data_connections_router.ts
Show resolved
Hide resolved
also the build test failure is unrelated to this change: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/10072759210/job/27845358410?pr=7419#step:17:2014 |
...ts/direct_query_data_sources_components/connection_detail/direct_query_connection_detail.tsx
Outdated
Show resolved
Hide resolved
...urces_components/direct_query_data_connection/manage_direct_query_data_connections_table.tsx
Show resolved
Hide resolved
...urces_components/direct_query_data_connection/manage_direct_query_data_connections_table.tsx
Show resolved
Hide resolved
...urces_components/direct_query_data_connection/manage_direct_query_data_connections_table.tsx
Show resolved
Hide resolved
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-main main
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-main
# Create a new branch
git switch --create backport/backport-7419-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 289a7c0c1a1f0b4eec0d1b9608ff4f9c7f77c6b8
# Push it to GitHub
git push --set-upstream origin backport/backport-7419-to-main
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-main Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7419-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 289a7c0c1a1f0b4eec0d1b9608ff4f9c7f77c6b8
# Push it to GitHub
git push --set-upstream origin backport/backport-7419-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
I will manual create the forward-port |
…ct#7419) * Switch the tab orders Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add delete with MDS support Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add acc creation action in data connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> * mute the table row for integration action when feature flag is disabled and no obs installed Signed-off-by: Ryan Liang <jiallian@amazon.com> * add integration flyout in dataconnection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add discover forwarding action in connections table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Disable query in observability logs in data connections table action menu Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update the test of connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update the test of home panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the then for checking observability dashboards Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix delete Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin 2 Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin 3 test Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com>
…ch-project#7419)" This reverts commit 289a7c0.
… (#7461) * [2.16] Fix minor issues for Direct Query Datasource (#7419) * Switch the tab orders Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add delete with MDS support Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add acc creation action in data connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> * mute the table row for integration action when feature flag is disabled and no obs installed Signed-off-by: Ryan Liang <jiallian@amazon.com> * add integration flyout in dataconnection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add discover forwarding action in connections table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Disable query in observability logs in data connections table action menu Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update the test of connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update the test of home panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the then for checking observability dashboards Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix delete Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin 2 Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin 3 test Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix integration version Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix access control tab fetching for remote cluster (#7456) Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: Lu Yu <nluyu@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
… (#7461) * [2.16] Fix minor issues for Direct Query Datasource (#7419) * Switch the tab orders Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add delete with MDS support Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add acc creation action in data connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> * mute the table row for integration action when feature flag is disabled and no obs installed Signed-off-by: Ryan Liang <jiallian@amazon.com> * add integration flyout in dataconnection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add discover forwarding action in connections table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Disable query in observability logs in data connections table action menu Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update the test of connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update the test of home panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the then for checking observability dashboards Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix delete Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin 2 Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin 3 test Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix integration version Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix access control tab fetching for remote cluster (#7456) Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: Lu Yu <nluyu@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 6db84ea) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
… (#7461) * [2.16] Fix minor issues for Direct Query Datasource (#7419) * Switch the tab orders Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add delete with MDS support Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add acc creation action in data connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> * mute the table row for integration action when feature flag is disabled and no obs installed Signed-off-by: Ryan Liang <jiallian@amazon.com> * add integration flyout in dataconnection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add discover forwarding action in connections table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Disable query in observability logs in data connections table action menu Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update the test of connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update the test of home panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the then for checking observability dashboards Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix delete Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin 2 Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin 3 test Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix integration version Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix access control tab fetching for remote cluster (#7456) Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: Lu Yu <nluyu@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit 6db84ea) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
… (#7461) (#7491) * [2.16] Fix minor issues for Direct Query Datasource (#7419) * Switch the tab orders * Add delete with MDS support * Add acc creation action in data connection table * Fix snapshots * mute the table row for integration action when feature flag is disabled and no obs installed * add integration flyout in dataconnection table * Add discover forwarding action in connections table * Disable query in observability logs in data connections table action menu * Update the test of connection table * Update the test of home panel * Fix the then for checking observability dashboards * Fix delete * fix check plugin * fix check plugin 2 * fix check plugin 3 test --------- * Fix integration version * Fix access control tab fetching for remote cluster (#7456) * Fix snapshots --------- (cherry picked from commit 6db84ea) Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <nluyu@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
… (#7461) (#7490) * [2.16] Fix minor issues for Direct Query Datasource (#7419) * Switch the tab orders * Add delete with MDS support * Add acc creation action in data connection table * Fix snapshots * mute the table row for integration action when feature flag is disabled and no obs installed * add integration flyout in dataconnection table * Add discover forwarding action in connections table * Disable query in observability logs in data connections table action menu * Update the test of connection table * Update the test of home panel * Fix the then for checking observability dashboards * Fix delete * fix check plugin * fix check plugin 2 * fix check plugin 3 test --------- * Fix integration version * Fix access control tab fetching for remote cluster (#7456) * Fix snapshots --------- (cherry picked from commit 6db84ea) Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <nluyu@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
…search-project#7419) (opensearch-project#7461) * [2.16] Fix minor issues for Direct Query Datasource (opensearch-project#7419) * Switch the tab orders Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add delete with MDS support Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add acc creation action in data connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> * mute the table row for integration action when feature flag is disabled and no obs installed Signed-off-by: Ryan Liang <jiallian@amazon.com> * add integration flyout in dataconnection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add discover forwarding action in connections table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Disable query in observability logs in data connections table action menu Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update the test of connection table Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update the test of home panel Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the then for checking observability dashboards Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix delete Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin 2 Signed-off-by: Ryan Liang <jiallian@amazon.com> * fix check plugin 3 test Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix integration version Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix access control tab fetching for remote cluster (opensearch-project#7456) Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: Lu Yu <nluyu@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
This PR will be forwardported into both
main
and2.x
Description
[2.16] Fix minor issues for Direct Query Datasource
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration