Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.17] [Page Header] Add responsiveness for page header #8231

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[Backport 2.17] [Page Header] Add responsiveness for page header #8231

merged 1 commit into from
Sep 23, 2024
+16,649 −13,803

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 636f399 from #8171.

@github-actions
[Page Headder]Add responsiveness for page header (#8171)
b8e2da5 
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
(cherry picked from commit 636f399)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry look & feel Look and Feel Improvements 2.17.1 labels Sep 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@github-actions github-actions bot removed the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Sep 18, 2024
@zhongnansu zhongnansu added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Sep 18, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.41176% with 14 lines in your changes missing coverage. Please review.

Project coverage is 63.94%. Comparing base (10bb541) to head (b8e2da5).
Report is 13 commits behind head on 2.17.

Files with missing lines Patch % Lines
src/core/public/chrome/ui/header/header.tsx 79.41% 0 Missing and 14 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             2.17    #8231   +/-   ##
=======================================
  Coverage   63.93%   63.94%           
=======================================
  Files        3737     3737           
  Lines       88749    88797   +48     
  Branches    13802    13815   +13     
=======================================
+ Hits        56745    56780   +35     
+ Misses      31406    31405    -1     
- Partials      598      612   +14
Flag Coverage Δ
Linux_1 29.94% <1.47%> (-0.02%) ⬇️
Linux_2 58.97% <79.41%> (+0.02%) ⬆️
Linux_3 40.24% <1.47%> (?)
Linux_4 31.29% <1.47%> (-0.03%) ⬇️
Windows_1 29.95% <1.47%> (-0.02%) ⬇️
Windows_2 58.92% <79.41%> (+0.02%) ⬆️
Windows_3 40.24% <1.47%> (-0.04%) ⬇️
Windows_4 31.29% <1.47%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongnansu zhongnansu merged commit 4803961 into 2.17 Sep 23, 2024
69 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@zhongnansu zhongnansu zhongnansu approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
2.17.1 autocut Skip the changelog verification check on backports look & feel Look and Feel Improvements Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@virajsanghvi @zhongnansu