Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manual backport 2.x] Update Discover appearance (#8651) #8661

Closed
wants to merge 1 commit into from
Closed

[Manual backport 2.x] Update Discover appearance (#8651) #8661

wants to merge 1 commit into from

Conversation

AMoo-Miki
Copy link
Collaborator

cherry picked commit 17103ba from #8651

@AMoo-Miki @opensearch-changeset-bot
Update Discover appearance (opensearch-project#8651)
fdf337d 
* Update Discover appearance

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR opensearch-project#8651 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

(cherry picked from commit 17103ba)
Signed-off-by: Miki <miki@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@AMoo-Miki AMoo-Miki changed the title Update Discover appearance (#8651) [Manual backport 2.x] Update Discover appearance (#8651) Oct 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@AMoo-Miki AMoo-Miki mentioned this pull request Oct 19, 2024
Closed
@AMoo-Miki AMoo-Miki added the discover for discover reinvent label Oct 19, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.94%. Comparing base (dff25a9) to head (fdf337d).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../data_explorer/public/components/sidebar/index.tsx 25.00% 2 Missing and 1 partial ⚠️
...ta/public/ui/dataset_selector/dataset_selector.tsx 66.66% 1 Missing and 1 partial ⚠️
...ugins/data/public/ui/filter_bar/filter_options.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #8661      +/-   ##
==========================================
- Coverage   60.95%   60.94%   -0.01%     
==========================================
  Files        3786     3786              
  Lines       90212    90221       +9     
  Branches    14126    14129       +3     
==========================================
+ Hits        54988    54989       +1     
- Misses      31758    31762       +4     
- Partials     3466     3470       +4
Flag Coverage Δ
Linux_1 29.05% <28.57%> (-0.08%) ⬇️
Linux_2 56.53% <ø> (ø)
Linux_3 37.74% <50.00%> (-0.01%) ⬇️
Linux_4 29.92% <28.57%> (-0.11%) ⬇️
Windows_1 29.06% <28.57%> (-0.08%) ⬇️
Windows_2 56.49% <ø> (ø)
Windows_3 ?
Windows_4 29.92% <28.57%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki
Copy link
Collaborator Author

AMoo-Miki commented Oct 19, 2024 •
edited
Loading

Combined in #8663

@AMoo-Miki AMoo-Miki closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
discover for discover reinvent discover-next failed changeset v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AMoo-Miki