Fix No data selected appearance #8668

AMoo-Miki · 2024-10-19T18:20:32Z

Post #8665

Fix No data selected appearance
Also:

Fix some React errors

Changelog

skip

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

AMoo-Miki · 2024-10-19T18:21:33Z

src/plugins/data/public/ui/query_editor/editors/default_editor/index.tsx

-              <EuiFlexItem grow={false} className="defaultEditor__footerItem">
+            {footerItems.start?.map((item, idx) => (
+              <EuiFlexItem
+                key={`defaultEditor__footerItem-start-${idx}`}


Just added key to get rid of react warning.

AMoo-Miki · 2024-10-19T18:21:37Z

src/plugins/data/public/ui/query_editor/editors/default_editor/index.tsx

-              <EuiFlexItem grow={false} className="defaultEditor__footerItem">
+            {footerItems.end?.map((item, idx) => (
+              <EuiFlexItem
+                key={`defaultEditor__footerItem-end-${idx}`}


Just added key to get rid of react warning.

AMoo-Miki · 2024-10-19T18:22:06Z

src/plugins/data/public/ui/filter_bar/filter_options.tsx

@@ -88,8 +88,7 @@ const FilterOptionsUI = (props: Props) => {
  const uiSettings = opensearchDashboards.services.uiSettings;
  const isPinned = uiSettings!.get(UI_SETTINGS.FILTERS_PINNED_BY_DEFAULT);
  const useNewHeader = Boolean(uiSettings!.get(UI_SETTINGS.NEW_HOME_PAGE));
-  const [indexPattern] = props.indexPatterns;
-  const index = indexPattern && indexPattern.id;
+  const index = Array.isArray(props.indexPatterns) ? props.indexPatterns[0]?.id : undefined;


Needed to make the no-index-pattern state to pass through.

AMoo-Miki · 2024-10-19T18:22:33Z

src/plugins/data/public/ui/query_editor/language_selector.tsx

@@ -111,7 +111,6 @@ export const QueryLanguageSelector = (props: QueryLanguageSelectorProps) => {
      button={
        <EuiSmallButtonEmpty
          iconSide="right"
-          iconSize="s"


EuiSmallButtonEmpty doesn't handle it, even tough it claims to do.

AMoo-Miki · 2024-10-19T18:23:35Z

src/plugins/discover/public/application/view_components/canvas/index.tsx

-          </EuiPanel>
-        )}
-      </>
+      {indexPattern ? (


Added the else to stop showing the spinner.

codecov · 2024-10-19T18:34:55Z

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 60.85%. Comparing base (e23f332) to head (cecbf95).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...ublic/application/view_components/canvas/index.tsx	0.00%	8 Missing ⚠️
...c/ui/query_editor/editors/default_editor/index.tsx	0.00%	2 Missing ⚠️
...ugins/data/public/ui/filter_bar/filter_options.tsx	0.00%	0 Missing and 1 partial ⚠️
...c/plugins/data/public/ui/search_bar/search_bar.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8668      +/-   ##
==========================================
- Coverage   60.86%   60.85%   -0.01%     
==========================================
  Files        3793     3793              
  Lines       90367    90368       +1     
  Branches    14182    14181       -1     
==========================================
- Hits        55000    54995       -5     
- Misses      31890    31895       +5     
- Partials     3477     3478       +1

Flag	Coverage Δ
Linux_1	`29.09% <0.00%> (-0.01%)`	⬇️
Linux_2	`56.39% <ø> (ø)`
Linux_3	`37.68% <0.00%> (-0.01%)`	⬇️
Linux_4	`29.82% <0.00%> (-0.01%)`	⬇️
Windows_1	`29.11% <0.00%> (-0.01%)`	⬇️
Windows_2	`56.34% <ø> (ø)`
Windows_3	`37.68% <0.00%> (-0.01%)`	⬇️
Windows_4	`29.82% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also: * Fix some React errors Signed-off-by: Miki <miki@amazon.com>

Also: * Fix some React errors Signed-off-by: Miki <miki@amazon.com> --------- Fix random big number during loading in query editor result (opensearch-project#8650) * Fix random big number during loading in query editor result Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Changeset file for PR opensearch-project#8650 created/updated * Fix initial loading number Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit a7414f0) --------- [bug] address different issues with dataset selector (opensearch-project#8665) * [bug] address some issues with dataset selector Moved the dataset selector back to the search bar and access it by ref in the sidebar. Avoid out of sync issue. * update the logic for ensuring index pattern * dont add ability to open button * empty state but missing data set selector button * fix tests * add back styling Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e23f332) --------- [bug] Discover UI stuck on searching after deleting index pattern (opensearch-project#8659) * [bug] Discover UI stuck on searching after deleting index pattern When using Discover with query enhancement enabled, deleting an index pattern from Index Management does not properly update the "Recently selected data" list in Discover. This causes the UI to become stuck in a "Searching" state when attempting to use Discover after deleting an index pattern. Handle the error case where the use index patterns hook caught error when enhancements was enabled. issue resolved: opensearch-project#8612 (cherry picked from commit 4808094) --------- [Discover]Sample Queries and Saved Queries in No Results Page (opensearch-project#8616) * Sample Queries and Saved Queries in No Results Page Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR opensearch-project#8616 created/updated * Update styling Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 9da1b77) --------- Improve Empty State Handling: Add No Index Patterns Panel with Data Selection in Discover View (opensearch-project#8613) * Improve Empty State Handling: Add No Index Patterns Panel with Data Selection in Discover View This PR primarily addresses the scenario when no index patterns (general) is available in the Discover view. Instead of redirecting users to the index management page, it introduces a new "No Index Patterns" panel. This panel provides users with the option to open a data selector and add index patterns directly from the Discover view, improving the user experience for new or empty deployments. To achieve, we move the selectedDataset state from ConnectedDatasetSelector to the app container's state management. This allows the AdvancedSelector, opened from the AppContainer, to update the dataset state effectively. Key changes include: * Implementing NoIndexPatternsPanel and AdvancedSelector components. * Refactoring dataset state management in AppContainer and Sidebar. * Modifying DiscoverCanvas to conditionally render NoIndexPatternsPanel. * Updating ConnectedDatasetSelector to use shared state and dataset change handling. * Update design of no data selected * use i18n * fix comments * Update design of no data selected * fix lint error Signed-off-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 6659139) --------- Update Discover appearance (opensearch-project#8651) * Update Discover appearance Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 17103ba) --------- Move DatasetSelector from data plugin queryString comp to DataExplorer (opensearch-project#8598) * Move DatasetSelector to DataExplorer * Style Disover after moving DatasetSelector to DataExplorer * fix the test by adding the getUpdates$ method to the mock queryString object Signed-off-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 923cce8)

AMoo-Miki · 2024-10-19T19:16:52Z

Manually backported to 2.x with #8670

Also: * Fix some React errors Signed-off-by: Miki <miki@amazon.com>

…, #8650, #8668 (#8670) * Fix No data selected appearance (#8668) Also: * Fix some React errors Signed-off-by: Miki <miki@amazon.com> --------- Fix random big number during loading in query editor result (#8650) * Fix random big number during loading in query editor result Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Changeset file for PR #8650 created/updated * Fix initial loading number Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit a7414f0) --------- [bug] address different issues with dataset selector (#8665) * [bug] address some issues with dataset selector Moved the dataset selector back to the search bar and access it by ref in the sidebar. Avoid out of sync issue. * update the logic for ensuring index pattern * dont add ability to open button * empty state but missing data set selector button * fix tests * add back styling Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e23f332) --------- [bug] Discover UI stuck on searching after deleting index pattern (#8659) * [bug] Discover UI stuck on searching after deleting index pattern When using Discover with query enhancement enabled, deleting an index pattern from Index Management does not properly update the "Recently selected data" list in Discover. This causes the UI to become stuck in a "Searching" state when attempting to use Discover after deleting an index pattern. Handle the error case where the use index patterns hook caught error when enhancements was enabled. issue resolved: #8612 (cherry picked from commit 4808094) --------- [Discover]Sample Queries and Saved Queries in No Results Page (#8616) * Sample Queries and Saved Queries in No Results Page Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #8616 created/updated * Update styling Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 9da1b77) --------- Improve Empty State Handling: Add No Index Patterns Panel with Data Selection in Discover View (#8613) * Improve Empty State Handling: Add No Index Patterns Panel with Data Selection in Discover View This PR primarily addresses the scenario when no index patterns (general) is available in the Discover view. Instead of redirecting users to the index management page, it introduces a new "No Index Patterns" panel. This panel provides users with the option to open a data selector and add index patterns directly from the Discover view, improving the user experience for new or empty deployments. To achieve, we move the selectedDataset state from ConnectedDatasetSelector to the app container's state management. This allows the AdvancedSelector, opened from the AppContainer, to update the dataset state effectively. Key changes include: * Implementing NoIndexPatternsPanel and AdvancedSelector components. * Refactoring dataset state management in AppContainer and Sidebar. * Modifying DiscoverCanvas to conditionally render NoIndexPatternsPanel. * Updating ConnectedDatasetSelector to use shared state and dataset change handling. * Update design of no data selected * use i18n * fix comments * Update design of no data selected * fix lint error Signed-off-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 6659139) --------- Update Discover appearance (#8651) * Update Discover appearance Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 17103ba) --------- Move DatasetSelector from data plugin queryString comp to DataExplorer (#8598) * Move DatasetSelector to DataExplorer * Style Disover after moving DatasetSelector to DataExplorer * fix the test by adding the getUpdates$ method to the mock queryString object Signed-off-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 923cce8) * Resolve merge errors from manual backports Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com>

Also: * Fix some React errors Signed-off-by: Miki <miki@amazon.com>

github-actions bot added distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Oct 19, 2024

AMoo-Miki commented Oct 19, 2024

View reviewed changes

ashwin-pc previously approved these changes Oct 19, 2024

View reviewed changes

AMoo-Miki commented Oct 19, 2024

View reviewed changes

AMoo-Miki added backport 2.x discover for discover reinvent discover-next v2.18.0 labels Oct 19, 2024

Fix No data selected appearance

cecbf95

Also: * Fix some React errors Signed-off-by: Miki <miki@amazon.com>

AMoo-Miki dismissed ashwin-pc’s stale review via cecbf95 October 19, 2024 19:01

AMoo-Miki force-pushed the post-update branch from ba266ff to cecbf95 Compare October 19, 2024 19:01

AMoo-Miki mentioned this pull request Oct 19, 2024

[Mnaual backport 2.x] Combined #8598, #8651, #8613, #8616, #8659, #8665, #8650, #8668 #8670

Merged

sejli approved these changes Oct 19, 2024

View reviewed changes

AMoo-Miki removed the backport 2.x label Oct 19, 2024

ananzh approved these changes Oct 19, 2024

View reviewed changes

ashwin-pc merged commit 7da5443 into opensearch-project:main Oct 19, 2024
67 of 68 checks passed

ashwin-pc pushed a commit to ashwin-pc/OpenSearch-Dashboards that referenced this pull request Oct 19, 2024

Fix No data selected appearance (opensearch-project#8668)

4d05629

Also: * Fix some React errors Signed-off-by: Miki <miki@amazon.com>

Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024

Fix No data selected appearance (opensearch-project#8668)

a396339

Also: * Fix some React errors Signed-off-by: Miki <miki@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix No data selected appearance #8668

Fix No data selected appearance #8668

AMoo-Miki commented Oct 19, 2024

AMoo-Miki Oct 19, 2024

AMoo-Miki Oct 19, 2024

AMoo-Miki Oct 19, 2024

AMoo-Miki Oct 19, 2024

AMoo-Miki Oct 19, 2024

codecov bot commented Oct 19, 2024 •

edited

Loading

AMoo-Miki commented Oct 19, 2024

Fix No data selected appearance #8668

Fix No data selected appearance #8668

Conversation

AMoo-Miki commented Oct 19, 2024

Changelog

Check List

AMoo-Miki Oct 19, 2024

Choose a reason for hiding this comment

AMoo-Miki Oct 19, 2024

Choose a reason for hiding this comment

AMoo-Miki Oct 19, 2024

Choose a reason for hiding this comment

AMoo-Miki Oct 19, 2024

Choose a reason for hiding this comment

AMoo-Miki Oct 19, 2024

Choose a reason for hiding this comment

codecov bot commented Oct 19, 2024 • edited Loading

Codecov Report

AMoo-Miki commented Oct 19, 2024

codecov bot commented Oct 19, 2024 •

edited

Loading