Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add tests to github workflow #980

Closed
wants to merge 1 commit into from

Commits on Nov 27, 2021

  1. [CI] Add tests to github workflow

    Add unit tests to github workflow and also creating a "bad apples"
    environment variable. Some unit tests just fail on the CI for
    hardware issues. They should be improved but step one will be
    calling out the bad apples.
    
    Also due to the flakiness we can cache the previous run results
    and only run the tests that failed. It's too random to catch
    with the bad apples mechanism. But still added the continue on
    error for unit tests because it takes so long to re-run on the
    CI. So instead if it does fail we automatically comment there
    was a failure and ask them to re-run.
    
    Next step will be improving.
    
    Also needed to limit the amount of workers because otherwise the
    hardware can't handle well so then it will accidentally create conflicts.
    This means we get an accurate test run but it is slower on the CI.
    
    Included integration tests which worked out of the box.
    
    Included e2e tests as well but it the chrome driver for the application
    was different from github's chrome so to run it I just upgraded it for
    the test run. Not ideal, ideally we should probably set up a
    docker env and install the specific versions since we are now
    depending on github's virtual env and the dependencies they installed
    there. But at least this is a first pace.
    
    Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
    kavilla committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    e6909c0 View commit details
    Browse the repository at this point in the history