add test for DiscoveryExtension dependencies field

Signed-off-by: Frank Lou <mloufra@amazon.com>
opensearch-project · Dec 8, 2022 · 3818817 · 3818817
1 parent 533e653
commit 3818817
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/server/src/test/java/org/opensearch/extensions/ExtensionsOrchestratorTests.java b/server/src/test/java/org/opensearch/extensions/ExtensionsOrchestratorTests.java
@@ -219,6 +219,10 @@ public void testExtensionsDiscovery() throws Exception {
 
         List<DiscoveryExtension> expectedExtensionsList = new ArrayList<DiscoveryExtension>();
 
+        String expectedUniqueId = "uniqueid0";
+        Version expectedVersion = Version.fromString("2.0.0");
+        List<ExtensionDependency> dependency = List.of(new ExtensionDependency(expectedUniqueId, expectedVersion));
+
         expectedExtensionsList.add(
             new DiscoveryExtension(
                 "firstExtension",
@@ -269,6 +273,7 @@ public void testExtensionsDiscovery() throws Exception {
         assertEquals(expectedExtensionsList.size(), extensionsOrchestrator.extensionIdMap.values().size());
         assertTrue(expectedExtensionsList.containsAll(extensionsOrchestrator.extensionIdMap.values()));
         assertTrue(extensionsOrchestrator.extensionIdMap.values().containsAll(expectedExtensionsList));
+        assertEquals(expectedExtensionsList.get(expectedExtensionsList.size() - 1), dependency.get(0));
     }
 
     public void testNonUniqueExtensionsDiscovery() throws Exception {
@@ -309,6 +314,7 @@ public void testNonUniqueExtensionsDiscovery() throws Exception {
         assertEquals(expectedExtensionsList.size(), extensionsOrchestrator.extensionIdMap.values().size());
         assertTrue(expectedExtensionsList.containsAll(extensionsOrchestrator.extensionIdMap.values()));
         assertTrue(extensionsOrchestrator.extensionIdMap.values().containsAll(expectedExtensionsList));
+        assertEquals(expectedExtensionsList.get(expectedExtensionsList.size() - 1), emptyList());
     }
 
     public void testExtensionDependency() throws Exception {

diff --git a/...src/test/java/org/opensearch/extensions/action/ExtensionTransportActionsHandlerTests.java b/...src/test/java/org/opensearch/extensions/action/ExtensionTransportActionsHandlerTests.java
@@ -21,7 +21,6 @@
 import org.opensearch.common.util.PageCacheRecycler;
 import org.opensearch.extensions.DiscoveryExtension;
 import org.opensearch.extensions.ExtensionBooleanResponse;
-import org.opensearch.extensions.ExtensionDependency;
 import org.opensearch.extensions.RegisterTransportActionsRequest;
 import org.opensearch.extensions.rest.RestSendToExtensionActionTests;
 import org.opensearch.indices.breaker.NoneCircuitBreakerService;
@@ -40,7 +39,6 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashMap;
-import java.util.List;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
 

diff --git a/server/src/test/java/org/opensearch/extensions/rest/RestSendToExtensionActionTests.java b/server/src/test/java/org/opensearch/extensions/rest/RestSendToExtensionActionTests.java
@@ -29,7 +29,6 @@
 import org.opensearch.common.transport.TransportAddress;
 import org.opensearch.common.util.PageCacheRecycler;
 import org.opensearch.extensions.DiscoveryExtension;
-import org.opensearch.extensions.ExtensionDependency;
 import org.opensearch.indices.breaker.NoneCircuitBreakerService;
 import org.opensearch.plugins.PluginInfo;
 import org.opensearch.rest.RestHandler.Route;