Address code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
opensearch-project · Aug 14, 2024 · 3aaa56f · 3aaa56f
1 parent 958c4fb
commit 3aaa56f
Showing 1 changed file with 3 additions and 11 deletions.
diff --git a/.github/workflows/precommit.yml b/.github/workflows/precommit.yml
@@ -24,19 +24,11 @@ jobs:
         with:
           java-version: 17
           distribution: temurin
-      - name: Set JAVA11_HOME
-        # See please https://docs.gradle.org/8.10/userguide/upgrading_version_8.html#minimum_daemon_jvm_version
-        if: matrix.java == 11
+      - name: Set JAVA${{ matrix.java }}_HOME
         shell: bash
         run: |
-          echo "JAVA11_HOME=$JAVA_HOME_11_${{ runner.arch }}" >> $GITHUB_ENV
+          echo "JAVA${{ matrix.java }}_HOME=$JAVA_HOME_${{ matrix.java }_${{ runner.arch }}" >> $GITHUB_ENV
       - name: Run Gradle (precommit)
-        # See please https://docs.gradle.org/8.10-rc-1/userguide/upgrading_version_8.html#minimum_daemon_jvm_version
-        if: matrix.java == 11
         shell: bash
         run: |
-          ./gradlew javadoc precommit --parallel -Druntime.java=11
-      - name: Run Gradle (precommit)
-        if: matrix.java != 11
-        run: |
-          ./gradlew javadoc precommit --parallel
+          ./gradlew javadoc precommit --parallel -Druntime.java=${{ matrix.java }