Skip to content

Commit

Permalink
PR feedback changes
Browse files Browse the repository at this point in the history
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
  • Loading branch information
nknize committed Feb 25, 2022
1 parent 17af390 commit 6179852
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public void run() {
return;
}
for (int i = 0; i < 10; i++) {
// index data with mapping changes
// index data
IndexResponse response = client(dataNode).prepareIndex("myindex").setSource("field_" + i, "val").get();
assertEquals(DocWriteResponse.Result.CREATED, response.getResult());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1288,7 +1288,6 @@ private static List<String> getNames(Suggest.Suggestion.Entry<Suggest.Suggestion

private void createIndexAndMappingAndSettings(Settings settings, CompletionMappingBuilder completionMappingBuilder) throws IOException {
XContentBuilder mapping = jsonBuilder().startObject()
.startObject(MapperService.SINGLE_MAPPING_NAME)
.startObject("properties")
.startObject("test_field")
.field("type", "keyword")
Expand Down Expand Up @@ -1324,7 +1323,7 @@ private void createIndexAndMappingAndSettings(Settings settings, CompletionMappi

mapping = mapping.endArray();
}
mapping = mapping.endObject().endObject().endObject().endObject();
mapping = mapping.endObject().endObject().endObject();

assertAcked(
client().admin()
Expand Down

0 comments on commit 6179852

Please sign in to comment.