Self review

Signed-off-by: Suraj Singh <surajrider@gmail.com>
opensearch-project · Jul 19, 2023 · 7b67543 · 7b67543
1 parent c7f56fc
commit 7b67543
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 18 deletions.
diff --git a/server/src/main/java/org/opensearch/index/store/remote/metadata/RemoteSegmentMetadata.java b/server/src/main/java/org/opensearch/index/store/remote/metadata/RemoteSegmentMetadata.java
@@ -39,15 +39,6 @@ public class RemoteSegmentMetadata {
 
     private final byte[] segmentInfosBytes;
 
-    // private final long primaryTerm;
-    // private final long generation;
-    //
-    // private final long version;
-    //
-    // private final long length;
-    //
-    // private final String codec;
-
     public ReplicationCheckpoint getReplicationCheckpoint() {
         return replicationCheckpoint;
     }

diff --git a/server/src/main/java/org/opensearch/indices/replication/GetSegmentFilesResponse.java b/server/src/main/java/org/opensearch/indices/replication/GetSegmentFilesResponse.java
@@ -23,10 +23,6 @@
  */
 public class GetSegmentFilesResponse extends TransportResponse {
 
-    public List<StoreFileMetadata> getFiles() {
-        return files;
-    }
-
     List<StoreFileMetadata> files;
 
     public GetSegmentFilesResponse(List<StoreFileMetadata> files) {
@@ -37,6 +33,10 @@ public GetSegmentFilesResponse(StreamInput out) throws IOException {
         out.readList(StoreFileMetadata::new);
     }
 
+    public List<StoreFileMetadata> getFiles() {
+        return files;
+    }
+
     @Override
     public void writeTo(StreamOutput out) throws IOException {
         out.writeCollection(files);

diff --git a/server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTarget.java b/server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTarget.java
@@ -32,7 +32,6 @@
 import org.opensearch.indices.replication.common.ReplicationTarget;
 
 import java.io.IOException;
-import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
@@ -146,7 +145,7 @@ public void startReplication(ActionListener<Void> listener) {
         final StepListener<CheckpointInfoResponse> checkpointInfoListener = new StepListener<>();
         final StepListener<GetSegmentFilesResponse> getFilesListener = new StepListener<>();
 
-        logger.info(new ParameterizedMessage("Starting Replication Target: {}", description()));
+        logger.trace(new ParameterizedMessage("Starting Replication Target: {}", description()));
         // Get list of files to copy from this checkpoint.
         state.setStage(SegmentReplicationState.Stage.GET_CHECKPOINT_INFO);
         cancellableThreads.checkForCancel();
@@ -156,12 +155,10 @@ public void startReplication(ActionListener<Void> listener) {
             final List<StoreFileMetadata> filesToFetch = getFiles(checkpointInfo);
             state.setStage(SegmentReplicationState.Stage.GET_FILES);
             cancellableThreads.checkForCancel();
-            logger.info("--> Before getFiles {}", Arrays.toString(indexShard.store().directory().listAll()));
             source.getSegmentFiles(getId(), checkpointInfo.getCheckpoint(), filesToFetch, indexShard, getFilesListener);
         }, listener::onFailure);
 
         getFilesListener.whenComplete(response -> {
-            logger.info("--> After getFiles {}", Arrays.toString(indexShard.store().directory().listAll()));
             finalizeReplication(checkpointInfoListener.result(), getFilesListener.result());
             listener.onResponse(null);
         }, listener::onFailure);
@@ -262,7 +259,7 @@ private void finalizeReplication(CheckpointInfoResponse checkpointInfoResponse,
     @Override
     public void cancel(String reason) {
         if (finished.get() == false) {
-            logger.info(new ParameterizedMessage("Cancelling replication for target {}", description()));
+            logger.trace(new ParameterizedMessage("Cancelling replication for target {}", description()));
             cancellableThreads.cancel(reason);
             source.cancel();
         }