Fix flaky behavior of RemoteStoreRestoreIT.testRateLimitedRemoteDownl…

…oads Signed-off-by: Sachin Kale <kalsac@amazon.com>
opensearch-project · Sep 7, 2023 · 89b1d29 · 89b1d29
1 parent e6a7202
commit 89b1d29
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreRestoreIT.java b/server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreRestoreIT.java
@@ -408,7 +408,8 @@ public void testRateLimitedRemoteDownloads() throws Exception {
             }
             assertThat(downloadPauseTime, greaterThan(TimeValue.timeValueSeconds(randomIntBetween(5, 10)).nanos()));
         }, 30, TimeUnit.SECONDS);
-        ensureGreen(INDEX_NAME);
+        // Waiting for extended period for green state so that rate limit does not cause flakiness
+        ensureGreen(TimeValue.timeValueSeconds(120), INDEX_NAME);
         // This is required to get updated number from already active shards which were not restored
         assertEquals(shardCount, getNumShards(INDEX_NAME).totalNumShards);
         assertEquals(0, getNumShards(INDEX_NAME).numReplicas);

diff --git a/server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java b/server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
@@ -248,7 +248,6 @@ public ClusterMetadataManifest writeIncrementalMetadata(
      * @param clusterState current ClusterState
      * @param toUpload list of IndexMetadata to upload
      * @return {@code List<UploadedIndexMetadata>} list of IndexMetadata uploaded to remote
-     * @throws IOException
      */
     private List<UploadedIndexMetadata> writeIndexMetadataParallel(ClusterState clusterState, List<IndexMetadata> toUpload)
         throws IOException {
@@ -322,7 +321,6 @@ private List<UploadedIndexMetadata> writeIndexMetadataParallel(ClusterState clus
      * @param clusterState current ClusterState
      * @param indexMetadata {@link IndexMetadata} to upload
      * @param latchedActionListener listener to respond back on after upload finishes
-     * @throws IOException
      */
     private void writeIndexMetadataAsync(
         ClusterState clusterState,