Remove an existing field to get a non-existing field name

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
opensearch-project · Mar 25, 2024 · 955a84a · 955a84a
1 parent 8e87efb
commit 955a84a
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/modules/ingest-common/src/test/java/org/opensearch/ingest/common/CopyProcessorTests.java b/modules/ingest-common/src/test/java/org/opensearch/ingest/common/CopyProcessorTests.java
@@ -23,8 +23,10 @@ public class CopyProcessorTests extends OpenSearchTestCase {
 
     public void testCopyExistingField() throws Exception {
         IngestDocument ingestDocument = RandomDocumentPicks.randomIngestDocument(random());
+        String targetFieldName = RandomDocumentPicks.randomExistingFieldName(random(), ingestDocument);
+        // remove the target field to ensure that we get a non-existing field name
+        ingestDocument.removeField(targetFieldName);
         String sourceFieldName = RandomDocumentPicks.randomExistingFieldName(random(), ingestDocument);
-        String targetFieldName = sourceFieldName + "_" + randomAlphaOfLength(10);
         Processor processor = createCopyProcessor(sourceFieldName, targetFieldName, false, false, false);
         processor.execute(ingestDocument);
         assertThat(ingestDocument.hasField(targetFieldName), equalTo(true));
@@ -70,8 +72,11 @@ public void testCopyWithIgnoreMissing() throws Exception {
 
     public void testCopyWithRemoveSource() throws Exception {
         IngestDocument ingestDocument = RandomDocumentPicks.randomIngestDocument(random());
+        String targetFieldName = RandomDocumentPicks.randomExistingFieldName(random(), ingestDocument);
+        // remove the target field to ensure that we get a non-existing field name
+        ingestDocument.removeField(targetFieldName);
         String sourceFieldName = RandomDocumentPicks.randomExistingFieldName(random(), ingestDocument);
-        String targetFieldName = sourceFieldName + "_" + randomAlphaOfLength(10);
+
         Object sourceValue = ingestDocument.getFieldValue(sourceFieldName, Object.class);
 
         Processor processor = createCopyProcessor(sourceFieldName, targetFieldName, false, true, false);