Skip to content

Commit

Permalink
Fix IndexSettingsTests
Browse files Browse the repository at this point in the history
Updated the asserts in IndexSettingsTests to account for the new defaulting behavior.

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
  • Loading branch information
kartg committed Jan 4, 2023
1 parent 4339244 commit 99b81ae
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -974,10 +974,10 @@ public void testExtendedCompatibilityVersionForNonRemoteSnapshot() {
);
IndexSettings settings = new IndexSettings(metadata, Settings.EMPTY);
assertFalse(settings.isRemoteSnapshot());
assertNull(settings.getExtendedCompatibilitySnapshotVersion());
assertEquals(Version.CURRENT.minimumIndexCompatibilityVersion(), settings.getExtendedCompatibilitySnapshotVersion());
}

public void testExtendedCompatibilityVersionMissingKey() {
public void testExtendedCompatibilityVersionWithoutFeatureFlag() {
IndexMetadata metadata = newIndexMeta(
"index",
Settings.builder()
Expand All @@ -987,6 +987,6 @@ public void testExtendedCompatibilityVersionMissingKey() {
);
IndexSettings settings = new IndexSettings(metadata, Settings.EMPTY);
assertTrue(settings.isRemoteSnapshot());
assertNull(settings.getExtendedCompatibilitySnapshotVersion());
assertEquals(Version.CURRENT.minimumIndexCompatibilityVersion(), settings.getExtendedCompatibilitySnapshotVersion());
}
}

0 comments on commit 99b81ae

Please sign in to comment.