close BytesStreamOutput in CustomBinaryDocValuesField.bytes

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
opensearch-project · Mar 30, 2023 · aa5c38f · aa5c38f
1 parent 3aa3164
commit aa5c38f
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/server/src/main/java/org/opensearch/index/mapper/BinaryFieldMapper.java b/server/src/main/java/org/opensearch/index/mapper/BinaryFieldMapper.java
@@ -259,14 +259,15 @@ public BytesRef binaryValue() {
                 CollectionUtils.sortAndDedup(bytesList, Arrays::compareUnsigned);
                 int size = bytesList.stream().map(b -> b.length).reduce(0, Integer::sum);
                 int length = bytesList.size();
-                BytesStreamOutput out = new BytesStreamOutput(size + (length + 1) * 5);
-                out.writeVInt(length);  // write total number of values
-                for (byte[] value : bytesList) {
-                    int valueLength = value.length;
-                    out.writeVInt(valueLength);
-                    out.writeBytes(value, 0, valueLength);
+                try (BytesStreamOutput out = new BytesStreamOutput(size + (length + 1) * 5)) {
+                    out.writeVInt(length);  // write total number of values
+                    for (byte[] value : bytesList) {
+                        int valueLength = value.length;
+                        out.writeVInt(valueLength);
+                        out.writeBytes(value, 0, valueLength);
+                    }
+                    return out.bytes().toBytesRef();
                 }
-                return out.bytes().toBytesRef();
             } catch (IOException e) {
                 throw new OpenSearchException("Failed to get binary value", e);
             }