Apply suggestions from code review

Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Mikhail Khludnev <mkhludnev@users.noreply.github.com>
opensearch-project · Nov 26, 2024 · c7382e3 · c7382e3
1 parent 341e256
commit c7382e3
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/server/src/internalClusterTest/java/org/opensearch/search/fields/SearchIpFieldTermsIT.java b/server/src/internalClusterTest/java/org/opensearch/search/fields/SearchIpFieldTermsIT.java
@@ -133,14 +133,15 @@ public void testExceedMaxClauses() throws IOException {
         assertTermsHitCount(indexName, "addr", toQuery, expectMatches);
         assertTermsHitCount(indexName, "addr.idx", toQuery, expectMatches);
         try { // error from mapper/parser
-            assertTermsHitCount(indexName, "addr.dv", toQuery, expectMatches);
+           final SearchPhaseExecutionException ose = assertThrows(SearchPhaseExecutionException.class, () -> assertTermsHitCount(indexName, "addr.dv", toQuery, expectMatches));
+           assertTrue("exceeding on query building", ose.shardFailures()[0].getCause().getCause() instanceof IndexSearcher.TooManyClauses);
             fail();
         } catch (SearchPhaseExecutionException ose) {
             assertTrue("exceeding on query building", ose.shardFailures()[0].getCause().getCause() instanceof IndexSearcher.TooManyClauses);
         }
     }
 
-    public static String getFirstThreeOctets(String ipAddress) {
+    private static String getFirstThreeOctets(String ipAddress) {
         // Split the IP address by the dot delimiter
         String[] octets = ipAddress.split("\\.");