Rename listener methods

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
opensearch-project · Jul 22, 2024 · d1099e9 · d1099e9
1 parent 3714343
commit d1099e9
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/server/src/main/java/org/opensearch/common/remote/AbstractRemoteWritableEntityManager.java b/server/src/main/java/org/opensearch/common/remote/AbstractRemoteWritableEntityManager.java
@@ -47,7 +47,7 @@ protected RemoteWritableEntityStore getStore(AbstractRemoteWritableBlobEntity en
      * @param listener the listener to be notified when the write operation completes
      * @return an ActionListener for handling the write operation
      */
-    protected abstract ActionListener<Void> getWriteActionListener(
+    protected abstract ActionListener<Void> getWrappedWriteListener(
         String component,
         AbstractRemoteWritableBlobEntity remoteEntity,
         ActionListener<ClusterMetadataManifest.UploadedMetadata> listener
@@ -62,7 +62,7 @@ protected abstract ActionListener<Void> getWriteActionListener(
      * @param listener the listener to be notified when the read operation completes
      * @return an ActionListener for handling the read operation
      */
-    protected abstract ActionListener<Object> getReadActionListener(
+    protected abstract ActionListener<Object> getWrappedReadListener(
         String component,
         AbstractRemoteWritableBlobEntity remoteEntity,
         ActionListener<RemoteReadResult> listener
@@ -74,11 +74,11 @@ public void writeAsync(
         AbstractRemoteWritableBlobEntity entity,
         ActionListener<ClusterMetadataManifest.UploadedMetadata> listener
     ) {
-        getStore(entity).writeAsync(entity, getWriteActionListener(component, entity, listener));
+        getStore(entity).writeAsync(entity, getWrappedWriteListener(component, entity, listener));
     }
 
     @Override
     public void readAsync(String component, AbstractRemoteWritableBlobEntity entity, ActionListener<RemoteReadResult> listener) {
-        getStore(entity).readAsync(entity, getReadActionListener(component, entity, listener));
+        getStore(entity).readAsync(entity, getWrappedReadListener(component, entity, listener));
     }
 }
diff --git a/server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateAttributesManager.java b/server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateAttributesManager.java
@@ -78,7 +78,7 @@ public class RemoteClusterStateAttributesManager extends AbstractRemoteWritableE
     }
 
     @Override
-    protected ActionListener<Void> getWriteActionListener(
+    protected ActionListener<Void> getWrappedWriteListener(
         String component,
         AbstractRemoteWritableBlobEntity remoteEntity,
         ActionListener<ClusterMetadataManifest.UploadedMetadata> listener
@@ -90,7 +90,7 @@ protected ActionListener<Void> getWriteActionListener(
     }
 
     @Override
-    protected ActionListener<Object> getReadActionListener(
+    protected ActionListener<Object> getWrappedReadListener(
         String component,
         AbstractRemoteWritableBlobEntity remoteEntity,
         ActionListener<RemoteReadResult> listener

diff --git a/server/src/main/java/org/opensearch/gateway/remote/RemoteGlobalMetadataManager.java b/server/src/main/java/org/opensearch/gateway/remote/RemoteGlobalMetadataManager.java
@@ -157,7 +157,7 @@ public class RemoteGlobalMetadataManager extends AbstractRemoteWritableEntityMan
     }
 
     @Override
-    protected ActionListener<Void> getWriteActionListener(
+    protected ActionListener<Void> getWrappedWriteListener(
         String component,
         AbstractRemoteWritableBlobEntity remoteEntity,
         ActionListener<ClusterMetadataManifest.UploadedMetadata> listener
@@ -169,7 +169,7 @@ protected ActionListener<Void> getWriteActionListener(
     }
 
     @Override
-    protected ActionListener<Object> getReadActionListener(
+    protected ActionListener<Object> getWrappedReadListener(
         String component,
         AbstractRemoteWritableBlobEntity remoteEntity,
         ActionListener<RemoteReadResult> listener

diff --git a/server/src/main/java/org/opensearch/gateway/remote/RemoteIndexMetadataManager.java b/server/src/main/java/org/opensearch/gateway/remote/RemoteIndexMetadataManager.java
@@ -104,7 +104,7 @@ private void setIndexMetadataUploadTimeout(TimeValue newIndexMetadataUploadTimeo
     }
 
     @Override
-    protected ActionListener<Void> getWriteActionListener(
+    protected ActionListener<Void> getWrappedWriteListener(
         String component,
         AbstractRemoteWritableBlobEntity remoteEntity,
         ActionListener<ClusterMetadataManifest.UploadedMetadata> listener
@@ -116,7 +116,7 @@ protected ActionListener<Void> getWriteActionListener(
     }
 
     @Override
-    protected ActionListener<Object> getReadActionListener(
+    protected ActionListener<Object> getWrappedReadListener(
         String component,
         AbstractRemoteWritableBlobEntity remoteEntity,
         ActionListener<RemoteReadResult> listener

diff --git a/.../src/test/java/org/opensearch/common/remote/AbstractRemoteWritableEntityManagerTests.java b/.../src/test/java/org/opensearch/common/remote/AbstractRemoteWritableEntityManagerTests.java
@@ -44,7 +44,7 @@ public void testGetStoreWithUnknownEntityType() {
 
     private static class ConcreteRemoteWritableEntityManager extends AbstractRemoteWritableEntityManager {
         @Override
-        protected ActionListener<Void> getWriteActionListener(
+        protected ActionListener<Void> getWrappedWriteListener(
             String component,
             AbstractRemoteWritableBlobEntity remoteEntity,
             ActionListener<ClusterMetadataManifest.UploadedMetadata> listener
@@ -53,7 +53,7 @@ protected ActionListener<Void> getWriteActionListener(
         }
 
         @Override
-        protected ActionListener<Object> getReadActionListener(
+        protected ActionListener<Object> getWrappedReadListener(
             String component,
             AbstractRemoteWritableBlobEntity remoteEntity,
             ActionListener<RemoteReadResult> listener