Use 1 minute timeout for assertBusy validations and comments

Signed-off-by: Suraj Singh <surajrider@gmail.com>
opensearch-project · Jun 28, 2023 · e57f170 · e57f170
1 parent 9d7e2c4
commit e57f170
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/IndexingIT.java b/qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/IndexingIT.java
@@ -50,6 +50,7 @@
 import java.nio.charset.StandardCharsets;
 import java.util.List;
 import java.util.Map;
+import java.util.concurrent.TimeUnit;
 
 import static org.opensearch.cluster.routing.UnassignedInfo.INDEX_DELAYED_NODE_LEFT_TIMEOUT_SETTING;
 import static org.opensearch.rest.action.search.RestSearchAction.TOTAL_HITS_AS_INT_PARAM;
@@ -94,6 +95,11 @@ private void waitForSearchableDocs(String index, int shardCount, int replicaCoun
 
         // Verify segment store
         assertBusy(() -> {
+            /**
+             * Use default tabular output and sort response based on shard,segment,primaryOrReplica columns to allow line by
+             * line parsing where records related to a segment (e.g. _0) are chunked together with first record belonging
+             * to primary while remaining *replicaCount* records belongs to replica copies
+             * */
             Request segrepStatsRequest = new Request("GET", "/_cat/segments/" + index + "?s=shard,segment,primaryOrReplica");
             segrepStatsRequest.addParameter("h", "index,shard,primaryOrReplica,segment,docs.count");
             Response segrepStatsResponse = client().performRequest(segrepStatsRequest);
@@ -122,7 +128,7 @@ private void waitForSearchableDocs(String index, int shardCount, int replicaCoun
                     segmentsIndex++;
                 }
             }
-        });
+        }, 1, TimeUnit.MINUTES);
     }
 
     private void waitForClusterHealthWithNoShardMigration(String indexName, String status) throws IOException {
@@ -145,7 +151,7 @@ private void verifySegmentStats(String indexName) throws Exception {
                 String[] elements = statLine.split(" +");
                 assertEquals("Replica shard " + elements[0] + "not upto date with primary ", 0, Integer.parseInt(elements[2]));
             }
-        });
+        }, 1, TimeUnit.MINUTES);
     }
 
     public void testIndexing() throws IOException, ParseException {