Addressed comments

Signed-off-by: Ankit Kala <ankikala@amazon.com>
opensearch-project · Aug 21, 2023 · e732c64 · e732c64
1 parent 6661e43
commit e732c64
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/server/src/main/java/org/opensearch/cluster/metadata/MetadataUpdateSettingsService.java b/server/src/main/java/org/opensearch/cluster/metadata/MetadataUpdateSettingsService.java
@@ -133,6 +133,8 @@ public void updateSettings(
         indexScopedSettings.validate(
             normalizedSettings.filter(s -> Regex.isSimpleMatchPattern(s) == false), // don't validate wildcards
             false, // don't validate dependencies here we check it below never allow to change the number of shards
+            false,
+            true, // Ignore archived setting.
             true
         ); // validate internal or private index settings
         for (String key : normalizedSettings.keySet()) {

diff --git a/server/src/main/java/org/opensearch/common/settings/AbstractScopedSettings.java b/server/src/main/java/org/opensearch/common/settings/AbstractScopedSettings.java
@@ -496,7 +496,7 @@ public final void validate(final Settings settings, final boolean validateDepend
      * @see Setting#getSettingsDependencies(String)
      */
     public final void validate(final Settings settings, final boolean validateDependencies, final boolean validateInternalOrPrivateIndex) {
-        validate(settings, validateDependencies, false, true, validateInternalOrPrivateIndex);
+        validate(settings, validateDependencies, false, false, validateInternalOrPrivateIndex);
     }
 
     /**