Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support to measure latency through the telemetry metrics framework #11884

Closed
mgodwan opened this issue Jan 15, 2024 · 4 comments
Labels
enhancement Enhancement or improvement to existing feature or request Plugins

Comments

@mgodwan
Copy link
Member

mgodwan commented Jan 15, 2024

Is your feature request related to a problem? Please describe

Latency metrics are very useful to analyse any issues resulting in performance degradation.
Today, the telemetry metrics framework has support for counters but lack support for latency/resultant histograms.

It will be useful to have this support to measure various operations e.g. document level latencies like field parsing for geo-shapes, analyzers, complete document parsing, translog sync, etc.

Describe the solution you'd like

https://opentelemetry.io/docs/specs/otel/metrics/data-model/#histogram

Related component

Plugins

Describe alternatives you've considered

No response

Additional context

No response

@mgodwan mgodwan added enhancement Enhancement or improvement to existing feature or request untriaged labels Jan 15, 2024
@mgodwan
Copy link
Member Author

mgodwan commented Jan 15, 2024

@Gaganjuneja Thoughts?

@peternied
Copy link
Member

[Triage - attendees 1 2 3 4]
Thanks for creating this issue; however, it isn't being accepted due to being too large of an area - please consult other issues around telemetry and request instrumentation and build off of them or reword for a more specific requests. Please feel free to re-open after addressing the reason.

@reta
Copy link
Collaborator

reta commented Jan 17, 2024

@mgodwan please take a look at #10141, we've working on general metrics APIs, please share your thoughts and which paths / code flows you would like to add metrics for, what kind of metrics, etc.

@Gaganjuneja
Copy link
Contributor

@reta @peternied @mgodwan I am working on adding the histogram support. At present doing the poc to understand the difference between exponential histogram and explicit bucket histogram. @mgodwan as @reta mentioned, could you please provide the list of metrics, you want to publish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Plugins
Projects
None yet
Development

No branches or pull requests

4 participants