Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metric Framework] Adds support for Histogram metric #12062

Merged

Conversation

Gaganjuneja
Copy link
Contributor

@Gaganjuneja Gaganjuneja commented Jan 29, 2024

Description

As part of the #10238 we have added the Metrics Framework and support for just the counter type of metrics. We also need to add Histogram support to record the latency metrics also.

Related Issues

Resolves #12061
[#11884]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Libraries Lucene Upgrades and Libraries, Any 3rd party library that Core depends on, ex: nebula; team is respo labels Jan 29, 2024
@Gaganjuneja
Copy link
Contributor Author

@reta, Please take a look. I will add tests in the next commit.

Copy link
Contributor

❌ Gradle check result for d5239fe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Compatibility status:

Checks if related components are compatible with change a0b5034

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git]

Gagan Juneja added 11 commits February 5, 2024 23:55
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@Gaganjuneja Gaganjuneja force-pushed the main-metrics-framework-histogram branch from 4155898 to a0b5034 Compare February 5, 2024 18:29
Copy link
Contributor

github-actions bot commented Feb 5, 2024

✅ Gradle check result for a0b5034: SUCCESS

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 135 lines in your changes are missing coverage. Please review.

Comparison is base (a8dd6a0) 71.26% compared to head (a0b5034) 71.39%.
Report is 7 commits behind head on main.

Files Patch % Lines
...search/repositories/fs/ReloadableFsRepository.java 31.03% 40 Missing ⚠️
...h/index/codec/fuzzy/FuzzyFilterPostingsFormat.java 85.44% 18 Missing and 5 partials ⚠️
...java/org/opensearch/index/shard/StoreRecovery.java 0.00% 18 Missing and 2 partials ⚠️
.../main/java/org/opensearch/index/IndexSettings.java 50.00% 10 Missing ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 38.46% 7 Missing and 1 partial ⚠️
...ndex/codec/fuzzy/IndexInputImmutableLongArray.java 46.15% 7 Missing ⚠️
.../org/opensearch/index/codec/fuzzy/BloomFilter.java 90.74% 2 Missing and 3 partials ⚠️
...ava/org/opensearch/index/codec/fuzzy/FuzzySet.java 70.58% 2 Missing and 3 partials ⚠️
.../opensearch/index/codec/fuzzy/FuzzySetFactory.java 63.63% 2 Missing and 2 partials ⚠️
...ensearch/telemetry/metrics/noop/NoopHistogram.java 0.00% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12062      +/-   ##
============================================
+ Coverage     71.26%   71.39%   +0.12%     
- Complexity    59413    59572     +159     
============================================
  Files          4927     4937      +10     
  Lines        279662   280110     +448     
  Branches      40656    40703      +47     
============================================
+ Hits         199311   199984     +673     
+ Misses        63725    63530     -195     
+ Partials      16626    16596      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta self-requested a review February 5, 2024 22:44
@reta reta self-requested a review February 5, 2024 22:45
@reta reta merged commit a4bc4af into opensearch-project:main Feb 5, 2024
37 of 38 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Feb 5, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 5, 2024
* [Metric Framework] Adds support for Histogram metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Addresses review comments

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds change log

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixed spotless

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Removes explicit approach

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Removes explicit approach

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Addresses review comments

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
(cherry picked from commit a4bc4af)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Feb 6, 2024
* [Metric Framework] Adds support for Histogram metric



* Adds test



* Addresses review comments



* Adds change log



* Fixed spotless



* Fixes javadoc



* Fixes javadoc



* Fixes test



* Removes explicit approach



* Removes explicit approach



* Addresses review comments



---------



(cherry picked from commit a4bc4af)

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
…ect#12062)

* [Metric Framework] Adds support for Histogram metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Addresses review comments

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds change log

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixed spotless

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Removes explicit approach

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Removes explicit approach

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Addresses review comments

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…ect#12062)

* [Metric Framework] Adds support for Histogram metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Addresses review comments

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds change log

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixed spotless

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Removes explicit approach

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Removes explicit approach

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Addresses review comments

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ect#12062)

* [Metric Framework] Adds support for Histogram metric

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Addresses review comments

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Adds change log

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixed spotless

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Removes explicit approach

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Removes explicit approach

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Addresses review comments

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Libraries Lucene Upgrades and Libraries, Any 3rd party library that Core depends on, ex: nebula; team is respo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] [Metrics Framework] Add support for Histogram to record the latency metrics.
2 participants