-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metric Framework] Adds support for Histogram metric #12062
[Metric Framework] Adds support for Histogram metric #12062
Conversation
@reta, Please take a look. I will add tests in the next commit. |
❌ Gradle check result for d5239fe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change a0b5034 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git] |
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
4155898
to
a0b5034
Compare
* [Metric Framework] Adds support for Histogram metric Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds test Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Addresses review comments Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds change log Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixed spotless Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes test Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Removes explicit approach Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Removes explicit approach Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Addresses review comments Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> (cherry picked from commit a4bc4af) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* [Metric Framework] Adds support for Histogram metric * Adds test * Addresses review comments * Adds change log * Fixed spotless * Fixes javadoc * Fixes javadoc * Fixes test * Removes explicit approach * Removes explicit approach * Addresses review comments --------- (cherry picked from commit a4bc4af) Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
…ect#12062) * [Metric Framework] Adds support for Histogram metric Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds test Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Addresses review comments Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds change log Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixed spotless Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes test Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Removes explicit approach Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Removes explicit approach Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Addresses review comments Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
…ect#12062) * [Metric Framework] Adds support for Histogram metric Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds test Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Addresses review comments Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds change log Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixed spotless Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes test Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Removes explicit approach Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Removes explicit approach Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Addresses review comments Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
…ect#12062) * [Metric Framework] Adds support for Histogram metric Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds test Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Addresses review comments Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Adds change log Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixed spotless Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Fixes test Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Removes explicit approach Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Removes explicit approach Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Addresses review comments Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
As part of the #10238 we have added the Metrics Framework and support for just the counter type of metrics. We also need to add Histogram support to record the latency metrics also.
Related Issues
Resolves #12061
[#11884]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.