Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Interface Fixes for Star Tree Search #15604

Closed
sarthakaggarwal97 opened this issue Sep 3, 2024 · 0 comments · Fixed by #15603
Closed

[Feature Request] Interface Fixes for Star Tree Search #15604

sarthakaggarwal97 opened this issue Sep 3, 2024 · 0 comments · Fixed by #15603
Labels
enhancement Enhancement or improvement to existing feature or request Search:Aggregations v2.17.0

Comments

@sarthakaggarwal97
Copy link
Contributor

Is your feature request related to a problem? Please describe

Currently, there are scenarios where the number of star tree documents can exceed the segment max doc. In such cases, the caching of the query is not possible because we create a FixedBitSet with segment max doc, it can overflow when we perform a set operation for documents more than the star tree docs.

Describe the solution you'd like

This change should introduce two key improvements to the search flows:

Caching Decision Enhancement: The search flows now have access to the StarTreeMetadata, allowing them to make an informed decision on whether to cache a query or not. This decision is based on the segment's maximum document count and the number of star tree documents.

Graceful Handling of Missing Dimension Values: Previously, an assertion was raised when a child node corresponding to a dimension value was not found. This change removes that assertion, enabling the system to gracefully handle scenarios where a dimension value does not exist in the children.

Related component

Search:Aggregations

Describe alternatives you've considered

No response

Additional context

No response

@sarthakaggarwal97 sarthakaggarwal97 added enhancement Enhancement or improvement to existing feature or request untriaged labels Sep 3, 2024
@sarthakaggarwal97 sarthakaggarwal97 changed the title [Feature Request] <title> [Feature Request] Improvements for Star Tree Search Sep 3, 2024
@sarthakaggarwal97 sarthakaggarwal97 changed the title [Feature Request] Improvements for Star Tree Search [Feature Request] Interface Fixes for Star Tree Search Sep 3, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Aggregations v2.17.0
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants