Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SnapshotV2] Add timestamp of last successful fetch of pinned timestamps in node stats #15896

Closed
ltaragi opened this issue Sep 11, 2024 · 0 comments · Fixed by #15611
Closed
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Snapshots v2.18.0 Issues and PRs related to version 2.18.0

Comments

@ltaragi
Copy link
Contributor

ltaragi commented Sep 11, 2024

Is your feature request related to a problem? Please describe

We can add the timestamp for the last successful fetch of pinned timestamps to the node stats. This can help in identifying any lags in the fetching process.

Describe the solution you'd like

  • RemoteStorePinnedTimestampService has a static method getPinnedTimestamps(). The first value of the returned tuple is when the last fetch of pinned timestamps is triggered . This is the timestamp we need to add to node stats.
  • We want to ensure backward compatibility with version checks and check that cluster.remote_store.pinned_timestamps.enabled setting is set as true
  • Since we currently don't have a remote store specific metric in the node stats, we can create a new metric class and add this timestamp there

Related component

Storage:Snapshots

Describe alternatives you've considered

No response

Additional context

No response

@ltaragi ltaragi added enhancement Enhancement or improvement to existing feature or request untriaged Storage:Snapshots v2.18.0 Issues and PRs related to version 2.18.0 labels Sep 11, 2024
@ltaragi ltaragi self-assigned this Sep 11, 2024
@ltaragi ltaragi moved this from 🆕 New to 👀 In review in Storage Project Board Sep 11, 2024
@ltaragi ltaragi removed the untriaged label Sep 11, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Storage Project Board Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Snapshots v2.18.0 Issues and PRs related to version 2.18.0
Projects
Status: ✅ Done
1 participant