Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Map, List, and Set in org.opensearch.common.collect #6609

Closed
andrross opened this issue Mar 9, 2023 · 4 comments
Closed

Deprecate Map, List, and Set in org.opensearch.common.collect #6609

andrross opened this issue Mar 9, 2023 · 4 comments
Assignees
@diliproshitha
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers

Comments

@andrross
Copy link
Member

andrross commented Mar 9, 2023

Code links: Map, List, Set

These classes have been pass throughs to the java.util since Java 9. They are pretty harmless, except for the annoyance that sometimes your IDE imports the OpenSearch class and then has to fully qualify the java.util versions when you want to use those. The task here is to:

  • Add @Deprecated annotations to these classes
  • Replace all usages within the opensearch-project/OpenSearch repo with the java.util versions
@andrross andrross added enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers untriaged labels Mar 9, 2023
@diliproshitha
Copy link
Contributor

diliproshitha commented Mar 10, 2023 •
edited
Loading

Can I take this?

@andrross
Copy link
Member Author

andrross commented Mar 10, 2023 •
edited
Loading

Can I take this?

@diliproshitha Sure! I'll assign it to you.

diliproshitha added a commit to diliproshitha/OpenSearch that referenced this issue Mar 11, 2023
@diliproshitha
Deprecate Map, List, and Set in org.opensearch.common.collect (opense…
e700e75 
…arch-project#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>
@diliproshitha diliproshitha mentioned this issue Mar 11, 2023
Merged
@diliproshitha
Copy link
Contributor

Raised the following PR: #6631

diliproshitha added a commit to diliproshitha/OpenSearch that referenced this issue Mar 14, 2023
@diliproshitha
Deprecate Map, List, and Set in org.opensearch.common.collect - PR re…
182dd90 
…view points (opensearch-project#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>
diliproshitha added a commit to diliproshitha/OpenSearch that referenced this issue Mar 15, 2023
@diliproshitha
Deprecate Map, List, and Set in org.opensearch.common.collect - remov…
07c4018 
…ed associated tests (opensearch-project#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>
kotwanikunal pushed a commit that referenced this issue Mar 15, 2023
@diliproshitha
Deprecate Map, List, and Set in org.opensearch.common.collect (#6609) (…
defcdf9 
…#6631)

* Deprecate Map, List, and Set in org.opensearch.common.collect (#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>

* Deprecate Map, List, and Set in org.opensearch.common.collect - PR review points (#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>

* Deprecate Map, List, and Set in org.opensearch.common.collect - removed associated tests (#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>

---------

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>
kotwanikunal pushed a commit to kotwanikunal/OpenSearch that referenced this issue Mar 15, 2023
@diliproshitha @kotwanikunal
Deprecate Map, List, and Set in org.opensearch.common.collect (opense…
ff88815 
…arch-project#6609) (opensearch-project#6631)

* Deprecate Map, List, and Set in org.opensearch.common.collect (opensearch-project#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>

* Deprecate Map, List, and Set in org.opensearch.common.collect - PR review points (opensearch-project#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>

* Deprecate Map, List, and Set in org.opensearch.common.collect - removed associated tests (opensearch-project#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>

---------

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>
(cherry picked from commit defcdf9)
@kotwanikunal kotwanikunal mentioned this issue Mar 15, 2023
Merged
6 tasks
kotwanikunal added a commit that referenced this issue Mar 16, 2023
@kotwanikunal @diliproshitha
Deprecate Map, List, and Set in org.opensearch.common.collect (#6609) (…
4e45e44 
…#6631) (#6687)

* Deprecate Map, List, and Set in org.opensearch.common.collect (#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>

* Deprecate Map, List, and Set in org.opensearch.common.collect - PR review points (#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>

* Deprecate Map, List, and Set in org.opensearch.common.collect - removed associated tests (#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>

---------

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>
(cherry picked from commit defcdf9)

Co-authored-by: Dilip Roshitha <diliproshitha@gmail.com>
This was referenced Mar 22, 2023
Closed
Closed
Closed
Closed
mingshl pushed a commit to mingshl/OpenSearch-Mingshl that referenced this issue Mar 24, 2023
@kotwanikunal @diliproshitha @mingshl
Deprecate Map, List, and Set in org.opensearch.common.collect (opense…
759477e 
…arch-project#6609) (opensearch-project#6631) (opensearch-project#6687)

* Deprecate Map, List, and Set in org.opensearch.common.collect (opensearch-project#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>

* Deprecate Map, List, and Set in org.opensearch.common.collect - PR review points (opensearch-project#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>

* Deprecate Map, List, and Set in org.opensearch.common.collect - removed associated tests (opensearch-project#6609)

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>

---------

Signed-off-by: Dilip Roshitha <diliproshitha@gmail.com>
(cherry picked from commit defcdf9)

Co-authored-by: Dilip Roshitha <diliproshitha@gmail.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
@kotwanikunal
Copy link
Member

Resolved with #6786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diliproshitha diliproshitha

Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andrross @diliproshitha @kotwanikunal @minalsha