Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove DEFAULT_MAPPING_ERROR_MESSAGE from MapperService #7007

Closed
lukas-vlcek opened this issue Apr 5, 2023 · 0 comments · Fixed by #7008
Closed

[BUG] Remove DEFAULT_MAPPING_ERROR_MESSAGE from MapperService #7007

lukas-vlcek opened this issue Apr 5, 2023 · 0 comments · Fixed by #7008
Labels
bug Something isn't working

Comments

@lukas-vlcek
Copy link
Contributor

Describe the bug

To keep the code clean I suggest to remove DEFAULT_MAPPING_ERROR_MESSAGE. It is no longer relevant.

Due to the lack of better issue category I am opening this as a BUG but it should fall into "Tech-Debt".
@lukas-vlcek lukas-vlcek added bug Something isn't working untriaged labels Apr 5, 2023
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Apr 5, 2023
@lukas-vlcek
Remove outdated default ndex mapping error message
ced508e 
This error message is no longer relevant and should not be used now.

Closes: opensearch-project#7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
@lukas-vlcek lukas-vlcek mentioned this issue Apr 5, 2023
Merged
6 tasks
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Apr 5, 2023
@lukas-vlcek
Remove outdated default index mapping error message
778579c 
This error message is no longer relevant and should not be used now.

Closes: opensearch-project#7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Apr 5, 2023
@lukas-vlcek
Remove outdated default index mapping error message
cca96a6 
This error message is no longer relevant and should not be used now.

Closes: opensearch-project#7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Apr 5, 2023
@lukas-vlcek
Remove outdated default index mapping error message
e40b1b9 
This error message is no longer relevant and should not be used now.

Closes: opensearch-project#7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Apr 5, 2023
@lukas-vlcek
Remove outdated default index mapping error message
5d1b05d 
This error message is no longer relevant and should not be used now.

Closes: opensearch-project#7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Apr 5, 2023
@lukas-vlcek
Remove outdated default index mapping error message
d38daed 
This error message is no longer relevant and should not be used now.

Closes: opensearch-project#7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Apr 5, 2023
@lukas-vlcek
Remove outdated default index mapping error message
4f4b863 
This error message is no longer relevant and should not be used now.

Closes: opensearch-project#7007
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Apr 5, 2023
@lukas-vlcek
Remove outdated default index mapping error message
0948241 
This error message is no longer relevant and should not be used now.

Closes: opensearch-project#7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
@dbwiddis dbwiddis removed the untriaged label Apr 7, 2023
andrross pushed a commit to lukas-vlcek/OpenSearch that referenced this issue Sep 15, 2023
@lukas-vlcek @andrross
Remove outdated default index mapping error message
0ea59aa 
This error message is no longer relevant and should not be used now.

Closes: opensearch-project#7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
andrross pushed a commit that referenced this issue Sep 19, 2023
@lukas-vlcek
Remove outdated default index mapping error message (#7008)
2f7969a 
This error message is no longer relevant and should not be used now.

Closes: #7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
opensearch-trigger-bot bot pushed a commit that referenced this issue Sep 19, 2023
@github-actions
Remove outdated default index mapping error message (#7008)
b314a0c 
This error message is no longer relevant and should not be used now.

Closes: #7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
(cherry picked from commit 2f7969a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this issue Sep 20, 2023
@opensearch-trigger-bot @github-actions
Remove outdated default index mapping error message (#7008) (#10130)
1d89a54 
This error message is no longer relevant and should not be used now.

Closes: #7007


(cherry picked from commit 2f7969a)

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
brusic pushed a commit to brusic/OpenSearch that referenced this issue Sep 25, 2023
@lukas-vlcek @brusic
Remove outdated default index mapping error message (opensearch-proje…
7cfb789 
…ct#7008)

This error message is no longer relevant and should not be used now.

Closes: opensearch-project#7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this issue Oct 10, 2023
@lukas-vlcek @vikasvb90
Remove outdated default index mapping error message (opensearch-proje…
39faaf4 
…ct#7008)

This error message is no longer relevant and should not be used now.

Closes: opensearch-project#7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this issue Apr 25, 2024
@lukas-vlcek @shiv0408
Remove outdated default index mapping error message (opensearch-proje…
6311f33 
…ct#7008)

This error message is no longer relevant and should not be used now.

Closes: opensearch-project#7007

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove outdated default index mapping error message lukas-vlcek/OpenSearch
2 participants
@lukas-vlcek @dbwiddis