Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concurrent Segment Search] Enable Search ITs with Concurrent Segment Search #7440

Closed
yigithub opened this issue May 4, 2023 · 6 comments
Closed
Assignees
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request

Comments

@yigithub
Copy link
Member

yigithub commented May 4, 2023

Currently Search ITs do not run with Concurrent Search feature. We need to identify and enable the suite of existing IT that needs to run with this feature.

@yigithub yigithub converted this from a draft issue May 4, 2023
@mch2
Copy link
Member

mch2 commented May 9, 2023

@yigithub These look like sub-tasks with no description. Could you please link these back to a meta issue along with #7439, #7438, #7437 ?

@anasalkouz
Copy link
Member

@yigithub Please make sure to add the details for this issues

@anasalkouz anasalkouz added enhancement Enhancement or improvement to existing feature or request and removed untriaged labels May 31, 2023
@jed326
Copy link
Collaborator

jed326 commented Jun 30, 2023

Adding some more details --

As of #7356 there are now 3 ways to control Concurrent Segment Search: 1.) Feature Flag (Not Dynamic) 2.) Dynamic Cluster Setting 3.) Dynamic Index Setting

Currently, the Feature Flag is disabled for (almost) all java ITs so we do not have automated test coverage for concurrent search. The goal of this task is to come up with a way to automatically run the java ITs with concurrent segment search enabled.

Off the top of my head one solution is to enable the Concurrent Segment Search Feature Flag and then parameterize the tests using the dynamic cluster setting. However we would like to avoid adding the parameterization code to every single test if possible, so it would be good to come up with a solution where all of the controls are in one place.

@neetikasinghal
Copy link
Contributor

I will be working on this.

@neetikasinghal
Copy link
Contributor

neetikasinghal commented Jul 12, 2023

Created an issue with EE team to ask about a custom jenkins job to run the following command that run the entire test suite with concurrent search enabled:
./gradlew :server:internalClusterTest --tests "org.opensearch.search.*" -Dopensearch.experimental.feature.concurrent_segment_search.enabled=true

@jed326
Copy link
Collaborator

jed326 commented Aug 28, 2023

Remaining tasks are tracked in #9443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request
Projects
Status: Done
Development

No branches or pull requests

6 participants