Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom jenkins job for running concurrent search tests #3729

Closed
neetikasinghal opened this issue Jul 12, 2023 · 4 comments
Closed

Custom jenkins job for running concurrent search tests #3729

neetikasinghal opened this issue Jul 12, 2023 · 4 comments
Labels
enhancement New Enhancement

Comments

@neetikasinghal
Copy link

Is your feature request related to a problem? Please describe

Currently Search ITs do not run with Concurrent Search feature on the main branch as part of the gradle check. We are looking for a custom jenkins job that could run the tests with the feature flag on.

In order to run the tests, as of now, we need to run the command manually on the dev computer:
./gradlew :server:internalClusterTest --tests "org.opensearch.search.*" -Dopensearch.experimental.feature.concurrent_segment_search.enabled=true

Relates

Describe the solution you'd like

We would to have a jenkins job that can automatically run the tests with day with the feature flag on

Describe alternatives you've considered

No response

Additional context

No response

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Jul 13, 2023

From the offline discussion if this automation can be solved with Github Actions (using default GitHub Runners) that can be managed by @neetikasinghal and team, then the Jenkins solution is not required.

@neetikasinghal and team, please test the execution using GH Actions https://docs.github.com/en/actions/quickstart and update with the results here.

Sample examples of how we use the GH Actions in the build repo:
https://github.com/opensearch-project/opensearch-build/tree/main/.github/workflows

Adding @bbarani @peterzhuamazon @rishabh6788 @jordarlu

@sohami
Copy link
Contributor

sohami commented Jul 13, 2023

  1. We are working on concurrent segment search feature which is currently behind experimental flag. The changes with this feature will be exercised in all the search flow. So we want to run all the UTs and ITs in the OpenSearch repository with this feature flag enabled to catch all the issues.
  2. Currently we have to do that manually and that takes lot of time to run all the tests locally each time and because of randomizations in the test it produces different failures which becomes hard to keep track of.

The ask is if we can setup some automation (using the existing Jenkins mechanism from EE team) to run it automatically either on some events or as a cron at regular cadence. The command that needs to be executed will be below:

./gradlew assemble
./gradlew test -Dopensearch.experimental.feature.concurrent_segment_search.enabled=true
./gradlew internalClusterTest -Dopensearch.experimental.feature.concurrent_segment_search.enabled=true

@jordarlu jordarlu removed the untriaged Issues that have not yet been triaged label Jul 17, 2023
@neetikasinghal
Copy link
Author

We were able to solve this via a github action: https://github.com/neetikasinghal/OpenSearch/actions/runs/5626243180/workflow

@bbarani
Copy link
Member

bbarani commented Jul 21, 2023

Closing this issue as it was resolved using a different method.

@bbarani bbarani closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants