Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fixing unblock condition for index create block #9531

Closed
RS146BIJAY opened this issue Aug 24, 2023 · 1 comment
Closed

[BUG] Fixing unblock condition for index create block #9531

RS146BIJAY opened this issue Aug 24, 2023 · 1 comment
Labels
bug Something isn't working v2.10.0

Comments

@RS146BIJAY
Copy link
Contributor

Describe the bug
As of now condition check for releasing IndexCreate block is that there should be an existing IndexCreateBlock on the cluster and auto release of the index create block is enabled. Issue in this condition is it will always evaluates to true in alternate iterations if auto release is enabled. So first time block got applied because of less space. Then in subsequent iteration it will get released due to above bug. Since DiskThresoldMonitor is also resetting the last runtime milliseconds every time we add and release blocks, nodes once evaluated to be above high watermarkwill never removed from this list even if enough space is available on the node. So all the node will always be considered above high watermark. Thus reapplying block. This keeps going in a loop.

To Reproduce
Steps to reproduce the behavior:
Reduce the space on all the nodes on cluster such that all nodes are below high watermark. In first iteration of DiskThresholdMonitor, block will be added on the cluster. In the next it will be removed. This will keep on going in loop.

Expected behavior
DiskThresholdMonitor should only remove block incase any node is no longer breaching high watermark.

@sachinpkale
Copy link
Member

Fixed with #9437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.10.0
Projects
None yet
Development

No branches or pull requests

2 participants