Fixing unblock condition for index create block

[RS146BIJAY]

Background

#5852

Description

As of now condition check for releasing IndexCreate block is that there should be an existing IndexCreateBlock on the cluster and auto release of the index create block is enabled. Issue in this condition is it will always evaluates to true in alternate iterations if auto release is enabled. So first time block got applied because of less space. Then in subsequent iteration it will get released due to above bug. Since DiskThresoldMonitor is also resetting the last runtime milliseconds every time we add and release blocks, nodes once evaluated to be above high watermarkwill never removed from this list even if enough space is available on the node. So all the node will always be considered above high watermark. Thus reapplying block. This keeps going in a loop. This PR fixes this issue by correcting unblock criteria.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
#9531

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/23032/
• CommitID: 95990be
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

Compatibility status:

Checks if related components are compatible with change bf10ff7

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob

• URL: https://build.ci.opensearch.org/job/gradle-check/23061/
• CommitID: a445b85
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #9437 (89198f5) into main (a6c0bb3) will increase coverage by 0.11%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##               main    #9437      +/-   ##
============================================
+ Coverage     71.07%   71.19%   +0.11%     
- Complexity    57448    57504      +56     
============================================
  Files          4778     4778              
  Lines        270906   270912       +6     
  Branches      39584    39585       +1     
============================================
+ Hits         192555   192873     +318     
+ Misses        62173    61847     -326     
- Partials      16178    16192      +14     

Files Changed	Coverage Δ
...uster/routing/allocation/DiskThresholdMonitor.java	73.36% <85.71%> (-6.46%)	⬇️

... and 456 files with indirect coverage changes

[dbwiddis]

Generally LGTM but I'm not sure I understand what's being fixed. The linked issue in the comments hasn't been replaced. The change log refers to a blank issue number.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/23141/
• CommitID: c209e92

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteBlobWithRetries

• URL: https://build.ci.opensearch.org/job/gradle-check/23142/
• CommitID: 1a5ae92
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[opensearch-trigger-bot]

Compatibility status:

Checks if related components are compatible with change 48d4087

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/23154/
• CommitID: 139de42

[psychbot]

LGTM!
This will help avoid removal of the blocks in the very next invocation of disk threshold monitor.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/23290/
• CommitID: e34f986

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/23305/
• CommitID: 56df081

[sachinpkale]

Overall changes look good. Please link bug issue in the PR description also resolve the conflict with CHANGELOG.md

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/23382/
• CommitID: 89198f5

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9437-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4e688086bcab9d7274597f4e8cc59e7456673a83
# Push it to GitHub
git push --set-upstream origin backport/backport-9437-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9437-to-2.x.