-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing instrumentation in transport service #10042
Add tracing instrumentation in transport service #10042
Conversation
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 0133a16 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10042 +/- ##
============================================
+ Coverage 70.42% 71.14% +0.72%
- Complexity 57451 58130 +679
============================================
Files 4824 4825 +1
Lines 273918 273952 +34
Branches 39918 39918
============================================
+ Hits 192894 194900 +2006
+ Misses 64725 62726 -1999
- Partials 16299 16326 +27
|
@reta, I have fixed the failing test cases. Please take a look. |
server/src/main/java/org/opensearch/transport/TransportResponseHandler.java
Show resolved
Hide resolved
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10042-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 483c2e36f6c8f2e326279b3b0e598d21072bdc14
# Push it to GitHub
git push --set-upstream origin backport/backport-10042-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@Gaganjuneja could you please backport manually to |
…10042) * Add instrumentation to transport service Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add instrumentation to transport service Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
…10042) * Add instrumentation to transport service Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add instrumentation to transport service Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
…10042) * Add instrumentation to transport service Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add instrumentation to transport service Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
…10042) * Add instrumentation to transport service Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add instrumentation to transport service Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
…10042) * Add instrumentation to transport service Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add instrumentation to transport service Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add javadoc Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Add tracing instrumentation in transport service.
Related Issues
Resolves #8553
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.