-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade write lock to read lock before translog upload to remote store #10135
Conversation
… remote store (opensearch-project#9636)" This reverts commit b5cc002. Signed-off-by: Ashish Singh <ssashish@amazon.com>
Compatibility status:Checks if related components are compatible with change 1bec919 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/k-nn.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
|
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/index/translog/RemoteFsTranslog.java
Show resolved
Hide resolved
…ore (#10135) * Revert "Optimize read write lock constructs during translog upload to remote store (#9636)" This reverts commit b5cc002. Signed-off-by: Ashish Singh <ssashish@amazon.com> * Downgrade writelock to readlock during translog upload Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com> (cherry picked from commit cbff21d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10135-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cbff21d7ea58d3185b969df43f48de10e32180e2
# Push it to GitHub
git push --set-upstream origin backport/backport-10135-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…ore (opensearch-project#10135) * Revert "Optimize read write lock constructs during translog upload to remote store (opensearch-project#9636)" This reverts commit b5cc002. Signed-off-by: Ashish Singh <ssashish@amazon.com> * Downgrade writelock to readlock during translog upload Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
…ore (opensearch-project#10135) * Revert "Optimize read write lock constructs during translog upload to remote store (opensearch-project#9636)" This reverts commit b5cc002. Signed-off-by: Ashish Singh <ssashish@amazon.com> * Downgrade writelock to readlock during translog upload Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
…ore (opensearch-project#10135) * Revert "Optimize read write lock constructs during translog upload to remote store (opensearch-project#9636)" This reverts commit b5cc002. Signed-off-by: Ashish Singh <ssashish@amazon.com> * Downgrade writelock to readlock during translog upload Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
…ore (opensearch-project#10135) * Revert "Optimize read write lock constructs during translog upload to remote store (opensearch-project#9636)" This reverts commit b5cc002. Signed-off-by: Ashish Singh <ssashish@amazon.com> * Downgrade writelock to readlock during translog upload Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
…ore (opensearch-project#10135) * Revert "Optimize read write lock constructs during translog upload to remote store (opensearch-project#9636)" This reverts commit b5cc002. Signed-off-by: Ashish Singh <ssashish@amazon.com> * Downgrade writelock to readlock during translog upload Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
#10117
Related Issues
Resolves #10117 and #10133
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.