Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor async blob read to avoid blocking calls, support non multipa… #10192

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

kotwanikunal
Copy link
Member

…rt calls

Description

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…rt calls

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 65e9ec9

Incompatible components

Incompatible components: [https://github.com/opensearch-project/k-nn.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

Looks like Jenkins crashed again.

image

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal
Copy link
Member Author

#10137

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal
Copy link
Member Author

#10006

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #10192 (65e9ec9) into main (38db1df) will increase coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is 76.66%.

@@             Coverage Diff              @@
##               main   #10192      +/-   ##
============================================
+ Coverage     71.06%   71.11%   +0.04%     
- Complexity    58155    58182      +27     
============================================
  Files          4828     4828              
  Lines        274358   274369      +11     
  Branches      39987    39992       +5     
============================================
+ Hits         194985   195108     +123     
+ Misses        62989    62853     -136     
- Partials      16384    16408      +24     
Files Changed Coverage Δ
...rg/opensearch/repositories/s3/S3BlobContainer.java 76.61% <76.66%> (-3.62%) ⬇️

... and 478 files with indirect coverage changes

@andrross andrross merged commit 61495bf into opensearch-project:main Sep 29, 2023
65 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 29, 2023
…rt calls (#10192)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 61495bf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Oct 3, 2023
…rt calls (opensearch-project#10192)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
kotwanikunal pushed a commit that referenced this pull request Oct 3, 2023
…rt calls (#10192) (#10278)

(cherry picked from commit 61495bf)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
…rt calls (opensearch-project#10192)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
…rt calls (opensearch-project#10192)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…rt calls (opensearch-project#10192)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants