Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #10289

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Replace deprecated command with environment file #10289

merged 1 commit into from
Oct 3, 2023

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Oct 1, 2023

Description

Update .github/workflows/lucene-snapshots.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo "::set-output name=REVISION::$(git rev-parse --short HEAD)"

TO-BE

echo "REVISION=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT

Related Issues

Resolves #10288

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

Compatibility status:

Checks if related components are compatible with change 876b09a

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #10289 (876b09a) into main (e156582) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10289      +/-   ##
============================================
- Coverage     71.18%   71.15%   -0.03%     
+ Complexity    58241    58224      -17     
============================================
  Files          4830     4830              
  Lines        274592   274592              
  Branches      40020    40020              
============================================
- Hits         195469   195396      -73     
- Misses        62701    62811     +110     
+ Partials      16422    16385      -37     

see 438 files with indirect coverage changes

@reta reta merged commit 2098975 into opensearch-project:main Oct 3, 2023
39 of 64 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Oct 3, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2023
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
(cherry picked from commit 2098975)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch October 3, 2023 13:46
reta pushed a commit that referenced this pull request Oct 3, 2023
(cherry picked from commit 2098975)

Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Oct 3, 2023
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…10289)

Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
4 participants