Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional section of node analyzers into NodeInfo #10296

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- [S3 Repository] Add setting to control connection count for sync client ([#12028](https://github.com/opensearch-project/OpenSearch/pull/12028))
- Views, simplify data access and manipulation by providing a virtual layer over one or more indices ([#11957](https://github.com/opensearch-project/OpenSearch/pull/11957))
- Add Remote Store Migration Experimental flag and allow mixed mode clusters under same ([#11986](https://github.com/opensearch-project/OpenSearch/pull/11986))
- Add optional section of node analyzers into NodeInfo ([#10296](https://github.com/opensearch-project/OpenSearch/pull/10296))

### Dependencies
- Bump `log4j-core` from 2.18.0 to 2.19.0
Expand Down Expand Up @@ -64,6 +65,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Add task completion count in search backpressure stats API ([#10028](https://github.com/opensearch-project/OpenSearch/pull/10028/))
- Deprecate CamelCase `PathHierarchy` tokenizer name in favor to lowercase `path_hierarchy` ([#10894](https://github.com/opensearch-project/OpenSearch/pull/10894))
- Switched to more reliable OpenSearch Lucene snapshot location([#11728](https://github.com/opensearch-project/OpenSearch/pull/11728))
- Breaking change: "search_pipelines" metric is not included in NodesInfoRequest by default ([#10296](https://github.com/opensearch-project/OpenSearch/pull/10296))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to @dblock's comment. We don't want to bring breaking changes into 2.x. Can you separate out this change from this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh... I feel really badly about this one, since I never should have included the search_pipelines section in the default NodesInfoRequest. @lukas-vlcek was just cleaning up my mess.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could we address that separately?


### Deprecated

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@
"transport",
"http",
"plugins",
"ingest"
"ingest",
"analysis_components"
],
"description":"A comma-separated list of metrics you wish returned. Leave empty to return all."
}
Expand All @@ -69,7 +70,8 @@
"transport",
"http",
"plugins",
"ingest"
"ingest",
"analysis_components"
],
"description":"A comma-separated list of metrics you wish returned. Leave empty to return all."
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
"node_info test analysis_components":
- skip:
version: " - 2.99.99"
reason: "analysis_components metric was introduced in 3.0.0"
features: [arbitrary_key]

- do:
nodes.info:
metric: [ analysis_components ]

# Note: It will only stash the first node_id in the api response.
- set:
nodes._arbitrary_key_: node_id

- is_true: nodes
- is_true: cluster_name

- is_true: nodes.$node_id.analysis_components.analyzers
- is_true: nodes.$node_id.analysis_components.tokenizers
- is_true: nodes.$node_id.analysis_components.tokenFilters
- is_true: nodes.$node_id.analysis_components.charFilters
- is_true: nodes.$node_id.analysis_components.normalizers
- is_true: nodes.$node_id.analysis_components.plugins
Original file line number Diff line number Diff line change
@@ -0,0 +1,322 @@
/*
* SPDX-License-Identifier: Apache-2.0
*
* The OpenSearch Contributors require contributions made to
* this file be licensed under the Apache-2.0 license or a
* compatible open source license.
*/

package org.opensearch.action.admin.cluster.node.info;

import org.opensearch.common.collect.Tuple;
import org.opensearch.core.common.io.stream.StreamInput;
import org.opensearch.core.common.io.stream.StreamOutput;
import org.opensearch.core.common.io.stream.Writeable;
import org.opensearch.core.service.ReportingService;
import org.opensearch.core.xcontent.XContentBuilder;
import org.opensearch.index.analysis.AnalysisRegistry;
import org.opensearch.plugins.AnalysisPlugin;
import org.opensearch.plugins.PluginInfo;
import org.opensearch.plugins.PluginsService;

import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
import java.util.List;
import java.util.Objects;
import java.util.Set;
import java.util.SortedSet;
import java.util.TreeSet;
import java.util.stream.Collectors;

import static java.util.Collections.unmodifiableList;
import static java.util.Collections.unmodifiableSortedSet;

/**
* Information about node analysis components.
*
* Every node in the cluster contains several analysis components. Some are preconfigured, the rest come from
* {@link AnalysisPlugin}s installed on this node (such as org.opensearch.analysis.common.CommonAnalysisModulePlugin).
*
* @see org.opensearch.index.analysis.AnalysisRegistry
* @see org.opensearch.indices.analysis.AnalysisModule
*
* @opensearch.internal
* @opensearch.experimental
*/
public class NodeAnalysisComponents implements ReportingService.Info {

private final SortedSet<String> analyzersIds;

private final SortedSet<String> tokenizersIds;

private final SortedSet<String> tokenFiltersIds;

private final SortedSet<String> charFiltersIds;

private final SortedSet<String> normalizersIds;

private final List<NodeAnalysisComponents.AnalysisPluginComponents> nodeAnalysisPlugins;

public SortedSet<String> getAnalyzersIds() {
return this.analyzersIds;
}

public SortedSet<String> getTokenizersIds() {
return this.tokenizersIds;
}

public SortedSet<String> getTokenFiltersIds() {
return this.tokenFiltersIds;
}

public SortedSet<String> getCharFiltersIds() {
return this.charFiltersIds;
}

public SortedSet<String> getNormalizersIds() {
return this.normalizersIds;
}

public List<NodeAnalysisComponents.AnalysisPluginComponents> getNodeAnalysisPlugins() {
return nodeAnalysisPlugins;
}

public NodeAnalysisComponents(AnalysisRegistry analysisRegistry, PluginsService pluginsService) {
List<NodeAnalysisComponents.AnalysisPluginComponents> nodeAnalysisPlugins = new ArrayList<>();
List<Tuple<PluginInfo, AnalysisPlugin>> analysisPlugins = pluginsService.filterPluginsForPluginInfo(AnalysisPlugin.class);

Check warning on line 88 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L86-L88

Added lines #L86 - L88 were not covered by tests
for (Tuple<PluginInfo, AnalysisPlugin> plugin : analysisPlugins) {
nodeAnalysisPlugins.add(

Check warning on line 90 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L90

Added line #L90 was not covered by tests
new NodeAnalysisComponents.AnalysisPluginComponents(
plugin.v1().getName(),
plugin.v1().getClassname(),
plugin.v2().getAnalyzers().keySet(),
plugin.v2().getTokenizers().keySet(),
plugin.v2().getTokenFilters().keySet(),
plugin.v2().getCharFilters().keySet(),
plugin.v2().getHunspellDictionaries().keySet()

Check warning on line 98 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L92-L98

Added lines #L92 - L98 were not covered by tests
)
);
}
this.analyzersIds = ensureSorted(analysisRegistry.getNodeAnalyzersKeys());
this.tokenizersIds = ensureSorted(analysisRegistry.getNodeTokenizersKeys());
this.tokenFiltersIds = ensureSorted(analysisRegistry.getNodeTokenFiltersKeys());
this.charFiltersIds = ensureSorted(analysisRegistry.getNodeCharFiltersKeys());
this.normalizersIds = ensureSorted(analysisRegistry.getNodeNormalizersKeys());
this.nodeAnalysisPlugins = ensureNonEmpty(nodeAnalysisPlugins);
}

Check warning on line 108 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L101-L108

Added lines #L101 - L108 were not covered by tests

public NodeAnalysisComponents(
final Set<String> analyzersKeySet,
final Set<String> tokenizersKeySet,
final Set<String> tokenFiltersKeySet,
final Set<String> charFiltersKeySet,
final Set<String> normalizersKeySet,
final List<NodeAnalysisComponents.AnalysisPluginComponents> nodeAnalysisPlugins
) {
this.analyzersIds = ensureSorted(analyzersKeySet);
this.tokenizersIds = ensureSorted(tokenizersKeySet);
this.tokenFiltersIds = ensureSorted(tokenFiltersKeySet);
this.charFiltersIds = ensureSorted(charFiltersKeySet);
this.normalizersIds = ensureSorted(normalizersKeySet);
this.nodeAnalysisPlugins = ensureNonEmpty(nodeAnalysisPlugins);
}

/**
* This class represents analysis components provided by {@link org.opensearch.plugins.AnalysisPlugin}.
* There can be several plugins (or modules) installed on each cluster node.
*/
public static class AnalysisPluginComponents implements Comparable<NodeAnalysisComponents.AnalysisPluginComponents>, Writeable {

private final String pluginName;
private final String className;
private final SortedSet<String> analyzersIds;
private final SortedSet<String> tokenizersIds;
private final SortedSet<String> tokenFiltersIds;
private final SortedSet<String> charFiltersIds;
private final SortedSet<String> hunspellDictionaries;

public AnalysisPluginComponents(
final String pluginName,
final String className,
final Set<String> analyzersIds,
final Set<String> tokenizersIds,
final Set<String> tokenFiltersIds,
final Set<String> charFiltersIds,
final Set<String> hunspellDictionaries
) {
this.pluginName = pluginName;
this.className = className;
this.analyzersIds = unmodifiableSortedSet(new TreeSet<>(analyzersIds));
this.tokenizersIds = unmodifiableSortedSet(new TreeSet<>(tokenizersIds));
this.tokenFiltersIds = unmodifiableSortedSet(new TreeSet<>(tokenFiltersIds));
this.charFiltersIds = unmodifiableSortedSet(new TreeSet<>(charFiltersIds));
this.hunspellDictionaries = unmodifiableSortedSet(new TreeSet<>(hunspellDictionaries));
}

public AnalysisPluginComponents(StreamInput in) throws IOException {
this.pluginName = in.readString();
this.className = in.readString();
this.analyzersIds = unmodifiableSortedSet(new TreeSet<>(in.readSet(StreamInput::readString)));
this.tokenizersIds = unmodifiableSortedSet(new TreeSet<>(in.readSet(StreamInput::readString)));
this.tokenFiltersIds = unmodifiableSortedSet(new TreeSet<>(in.readSet(StreamInput::readString)));
this.charFiltersIds = unmodifiableSortedSet(new TreeSet<>(in.readSet(StreamInput::readString)));
this.hunspellDictionaries = unmodifiableSortedSet(new TreeSet<>(in.readSet(StreamInput::readString)));
}

Check warning on line 166 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L158-L166

Added lines #L158 - L166 were not covered by tests

public void writeTo(StreamOutput out) throws IOException {
out.writeString(this.pluginName);
out.writeString(this.className);
out.writeStringCollection(this.analyzersIds);
out.writeStringCollection(this.tokenizersIds);
out.writeStringCollection(this.tokenFiltersIds);
out.writeStringCollection(this.charFiltersIds);
out.writeStringCollection(this.hunspellDictionaries);
}

Check warning on line 176 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L169-L176

Added lines #L169 - L176 were not covered by tests

private static final Comparator<String> nullSafeStringComparator = Comparator.nullsFirst(String::compareTo);

private static String concatenateItems(SortedSet<String> items) {
return items.stream().collect(Collectors.joining());

Check warning on line 181 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L181

Added line #L181 was not covered by tests
}

/**
* This Comparator defines the comparison logic for sorting instances of AnalysisPluginComponents based on
* their attributes in the following order:
*
* 1. Plugin name (as specified in the plugin descriptor)
* 2. Class name
* 3. Analyzers IDs
* 4. Tokenizers IDs
* 5. TokenFilters IDs
* 6. CharFilters IDs
* 7. Hunspell dictionary IDs
*/
private static final Comparator<NodeAnalysisComponents.AnalysisPluginComponents> pluginComponentsComparator = Comparator.comparing(
AnalysisPluginComponents::getPluginName,
nullSafeStringComparator
)
.thenComparing(AnalysisPluginComponents::getClassName, nullSafeStringComparator)
.thenComparing(c -> concatenateItems(c.getAnalyzersIds()), nullSafeStringComparator)
.thenComparing(c -> concatenateItems(c.getTokenizersIds()), nullSafeStringComparator)
.thenComparing(c -> concatenateItems(c.getTokenFiltersIds()), nullSafeStringComparator)
.thenComparing(c -> concatenateItems(c.getCharFiltersIds()), nullSafeStringComparator)
.thenComparing(c -> concatenateItems(c.getHunspellDictionaries()), nullSafeStringComparator);

@Override
public int compareTo(NodeAnalysisComponents.AnalysisPluginComponents o) {
return pluginComponentsComparator.compare(this, o);

Check warning on line 209 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L209

Added line #L209 was not covered by tests
}

@Override
public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
AnalysisPluginComponents that = (AnalysisPluginComponents) o;

Check warning on line 216 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L216

Added line #L216 was not covered by tests
return Objects.equals(pluginName, that.pluginName)
&& Objects.equals(className, that.className)
&& Objects.equals(analyzersIds, that.analyzersIds)
&& Objects.equals(tokenizersIds, that.tokenizersIds)
&& Objects.equals(tokenFiltersIds, that.tokenFiltersIds)
&& Objects.equals(charFiltersIds, that.charFiltersIds)
&& Objects.equals(hunspellDictionaries, that.hunspellDictionaries);
}

@Override
public int hashCode() {
return Objects.hash(pluginName, className, analyzersIds, tokenizersIds, tokenFiltersIds, charFiltersIds, hunspellDictionaries);

Check warning on line 228 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L228

Added line #L228 was not covered by tests
}

public String getPluginName() {
return this.pluginName;

Check warning on line 232 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L232

Added line #L232 was not covered by tests
}

public String getClassName() {
return this.className;

Check warning on line 236 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L236

Added line #L236 was not covered by tests
}

public SortedSet<String> getAnalyzersIds() {
return this.analyzersIds;
}

public SortedSet<String> getTokenizersIds() {
return this.tokenizersIds;
}

public SortedSet<String> getTokenFiltersIds() {
return this.tokenFiltersIds;
}

public SortedSet<String> getCharFiltersIds() {
return this.charFiltersIds;
}

public SortedSet<String> getHunspellDictionaries() {
return this.hunspellDictionaries;
}
}

public NodeAnalysisComponents(StreamInput in) throws IOException {
this.analyzersIds = unmodifiableSortedSet(new TreeSet<>(in.readSet(StreamInput::readString)));
this.tokenizersIds = unmodifiableSortedSet(new TreeSet<>(in.readSet(StreamInput::readString)));
this.tokenFiltersIds = unmodifiableSortedSet(new TreeSet<>(in.readSet(StreamInput::readString)));
this.charFiltersIds = unmodifiableSortedSet(new TreeSet<>(in.readSet(StreamInput::readString)));
this.normalizersIds = unmodifiableSortedSet(new TreeSet<>(in.readSet(StreamInput::readString)));
this.nodeAnalysisPlugins = unmodifiableList(in.readList(NodeAnalysisComponents.AnalysisPluginComponents::new));
}

Check warning on line 267 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L260-L267

Added lines #L260 - L267 were not covered by tests

@Override
public void writeTo(StreamOutput out) throws IOException {
out.writeStringCollection(this.analyzersIds);
out.writeStringCollection(this.tokenizersIds);
out.writeStringCollection(this.tokenFiltersIds);
out.writeStringCollection(this.charFiltersIds);
out.writeStringCollection(this.normalizersIds);
out.writeList(this.nodeAnalysisPlugins);
}

Check warning on line 277 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L271-L277

Added lines #L271 - L277 were not covered by tests

@Override
public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException {
builder.startObject("analysis_components");
builder.field("analyzers").value(this.getAnalyzersIds());
builder.field("tokenizers").value(this.getTokenizersIds());
builder.field("tokenFilters").value(this.getTokenFiltersIds());
builder.field("charFilters").value(this.getCharFiltersIds());
builder.field("normalizers").value(this.getNormalizersIds());
builder.startArray("plugins");

Check warning on line 287 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L281-L287

Added lines #L281 - L287 were not covered by tests
for (NodeAnalysisComponents.AnalysisPluginComponents pluginComponents : this.getNodeAnalysisPlugins()) {
builder.startObject();
builder.field("name", pluginComponents.getPluginName());
builder.field("classname", pluginComponents.getClassName());
builder.field("analyzers").value(pluginComponents.getAnalyzersIds());
builder.field("tokenizers").value(pluginComponents.getTokenizersIds());
builder.field("tokenFilters").value(pluginComponents.getTokenFiltersIds());
builder.field("charFilters").value(pluginComponents.getCharFiltersIds());
builder.field("hunspellDictionaries").value(pluginComponents.getHunspellDictionaries());
builder.endObject();
}
builder.endArray();
builder.endObject();
return builder;

Check warning on line 301 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L289-L301

Added lines #L289 - L301 were not covered by tests
}

public int hashCode() {
return Objects.hash(analyzersIds, tokenizersIds, tokenFiltersIds, charFiltersIds, normalizersIds, nodeAnalysisPlugins);

Check warning on line 305 in server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/action/admin/cluster/node/info/NodeAnalysisComponents.java#L305

Added line #L305 was not covered by tests
}

/**
* Ensures that a given set of strings is sorted in "natural" order.
*
* See: {@link SortedSet}
*/
private static SortedSet<String> ensureSorted(Set<String> stringSet) {
return stringSet == null ? Collections.emptySortedSet() : unmodifiableSortedSet(new TreeSet<>(stringSet));
}

private static List<NodeAnalysisComponents.AnalysisPluginComponents> ensureNonEmpty(
List<NodeAnalysisComponents.AnalysisPluginComponents> pluginComponents
) {
return pluginComponents == null ? Collections.emptyList() : unmodifiableList(pluginComponents);
}
}
Loading
Loading