[Backport] [2.x] Update bundled JDK to JDK-21.0.1 (#10576)

[reta]

Backport of #10576 to 2.x

[reta]

@dblock @nknize @andrross switching bundled JDK in 2.x to JDK-21 as we discussed several times (primarily, to address #9423 & Apache Lucene's Panama usage)

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29259/
• CommitID: 9423fe1
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29260/
• CommitID: 3d7aa59
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Compatibility status:

Checks if related components are compatible with change cef267e

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29273/
• CommitID: aadc6eb
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

• URL: https://build.ci.opensearch.org/job/gradle-check/29375/
• CommitID: fa560e8
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #11003 (cef267e) into 2.x (822e253) will increase coverage by 0.00%.
Report is 1 commits behind head on 2.x.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                2.x   #11003   +/-   ##
=========================================
  Coverage     70.90%   70.90%           
- Complexity    58928    58957   +29     
=========================================
  Files          4862     4862           
  Lines        278394   278401    +7     
  Branches      40810    40812    +2     
=========================================
+ Hits         197396   197408   +12     
- Misses        64189    64280   +91     
+ Partials      16809    16713   -96     

Files	Coverage Δ
...a/org/opensearch/gradle/test/DistroTestPlugin.java	0.00% <ø> (ø)
.../opensearch/common/util/concurrent/BaseFuture.java	62.71% <ø> (ø)
...rg/opensearch/gradle/OpenSearchTestBasePlugin.java	6.38% <0.00%> (-0.22%)	⬇️
...g/opensearch/tools/launchers/SystemJvmOptions.java	0.00% <0.00%> (ø)

... and 466 files with indirect coverage changes

[peternied]

@reta I'm going to approve but as there might be downstream impact, please merge when you think it the best time

[reta]

@reta I'm going to approve but as there might be downstream impact, please merge when you think it the best time

Thanks a lot @peternied , I am waiting for @nknize @andrross @dblock @CEHENKLE signoff before moving forwards, the impact of this change (going unnoticed) is understood :)

[dblock]

I don't know what the implications of this change are.

[bbarani]

I don't know what the implications of this change are.

At a high level, this might cause Gradle compatibility issues across multiple repos so we need to start a campaign soon.

[reta]

At a high level, this might cause Gradle compatibility issues across multiple repos so we need to start a campaign soon.

Thanks @bbarani, for Gradle specifically - no issues and no changes, this is only runtime change (which is as important as Gradle): we would need to make sure that all plugins work under JDK-21 as a runtime.

I don't know what the implications of this change are.

Thanks @dblock , explained above

[dblock]

I don't have any strong opinions of when to merge this, your call @reta, PR approved.

IMO downstream plugin pain is not solvable without the kind of decoupling introduced by extensions

[reta]

Wouldn't it be better to merge early than later if we are targeting 2.12?

Sure, but this change needs awareness and alignment that it is OK to target 2.12

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/29810/
• CommitID: cef267e

[bbarani]

@dblock @reta @andrross What are the next steps? We will start incorporating the build changes in 2.x line based on the outcome.

[reta]

@dblock @reta @andrross What are the next steps? We will start incorporating the build changes in 2.x line based on the outcome.

@bbarani I will plan to merge it tomorrow

[reta]

Seeing no objections, merging JDK-21 into 2.x branch