Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.11] Disable sort optimization for HALF_FLOAT (#10999) #11005

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

gashutos
Copy link
Contributor

Backport of #10999

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>
@reta reta changed the title Disable sort optimization for HALF_FLOAT (#10999) [Backport] [2.11] Disable sort optimization for HALF_FLOAT (#10999) Oct 30, 2023
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change a2e1880

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Oct 30, 2023

URL: https://build.ci.opensearch.org/job/gradle-check/29267/

Should be fixed in 2.x, #10709

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #11005 (a2e1880) into 2.11 (fdf4b36) will increase coverage by 0.04%.
Report is 6 commits behind head on 2.11.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               2.11   #11005      +/-   ##
============================================
+ Coverage     70.86%   70.90%   +0.04%     
- Complexity    58496    58548      +52     
============================================
  Files          4830     4830              
  Lines        276379   276380       +1     
  Branches      40579    40579              
============================================
+ Hits         195852   195966     +114     
+ Misses        63826    63775      -51     
+ Partials      16701    16639      -62     
Files Coverage Δ
...ibs/core/src/main/java/org/opensearch/Version.java 83.62% <100.00%> (-0.37%) ⬇️
...nsearch/index/fielddata/IndexNumericFieldData.java 85.07% <100.00%> (ø)

... and 484 files with indirect coverage changes

@reta reta merged commit ac4de44 into opensearch-project:2.11 Oct 30, 2023
66 checks passed
@gashutos
Copy link
Contributor Author

Thanks you @reta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants