-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 1.3] Allow customization of netty channel handles before and during decompression (#10261) #11086
Merged
reta
merged 3 commits into
opensearch-project:1.3
from
peternied:improve-compressed-requests-1.3
Nov 9, 2023
Merged
[Backport 1.3] Allow customization of netty channel handles before and during decompression (#10261) #11086
reta
merged 3 commits into
opensearch-project:1.3
from
peternied:improve-compressed-requests-1.3
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d during decompression (opensearch-project#10261) Signed-off-by: Peter Nied <petern@amazon.com>
peternied
commented
Nov 3, 2023
...t-netty4/src/internalClusterTest/java/org/opensearch/http/netty4/Netty4HeaderVerifierIT.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Peter Nied <petern@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Peter Nied <petern@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 1.3 #11086 +/- ##
============================================
- Coverage 77.60% 77.56% -0.04%
+ Complexity 58812 58745 -67
============================================
Files 4223 4223
Lines 253440 253443 +3
Branches 38705 38705
============================================
- Hits 196672 196588 -84
- Misses 40789 40835 +46
- Partials 15979 16020 +41
|
@reta Could you take a look? |
reta
approved these changes
Nov 9, 2023
Thanks @peternied , apologies for missing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow customization of netty channel handles before and during decompression
Related Issues
Check List
New functionality has been documented.Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.