Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3] Allow customization of netty channel handles before and during decompression (#10261) #11086

Merged

Conversation

peternied
Copy link
Member

Description

Allow customization of netty channel handles before and during decompression

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…d during decompression (opensearch-project#10261)

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied marked this pull request as draft November 3, 2023 22:04
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Peter Nied <petern@amazon.com>
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #11086 (0198b94) into 1.3 (77adb21) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                1.3   #11086      +/-   ##
============================================
- Coverage     77.60%   77.56%   -0.04%     
+ Complexity    58812    58745      -67     
============================================
  Files          4223     4223              
  Lines        253440   253443       +3     
  Branches      38705    38705              
============================================
- Hits         196672   196588      -84     
- Misses        40789    40835      +46     
- Partials      15979    16020      +41     
Files Coverage Δ
...nsearch/http/netty4/Netty4HttpServerTransport.java 75.75% <100.00%> (+0.56%) ⬆️
...in/java/org/opensearch/transport/Netty4Plugin.java 89.47% <ø> (ø)

... and 455 files with indirect coverage changes

@peternied peternied marked this pull request as ready for review November 9, 2023 22:45
@peternied peternied requested a review from tlfeng as a code owner November 9, 2023 22:45
@peternied
Copy link
Member Author

@reta Could you take a look?

@reta reta merged commit 2e9bfca into opensearch-project:1.3 Nov 9, 2023
@reta
Copy link
Collaborator

reta commented Nov 9, 2023

@reta Could you take a look?

Thanks @peternied , apologies for missing this one

@peternied peternied deleted the improve-compressed-requests-1.3 branch November 10, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants