Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test cases for concurrent search #11119

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

e-emoto
Copy link
Contributor

@e-emoto e-emoto commented Nov 6, 2023

Description

This makes use of the indexRandomForConcurrentSearch function, which creates more segments for concurrent search tests, in several test cases for their concurrent search use-cases. The following test suites are affected by this change:

  • DerivativeIT.java
  • MovAvgIT.java
  • SearchRedStateIndexIT.java
  • SearchWhileCreatingIndexIT.java
  • TransportTwoNodesSearchIT.java
  • RandomScoreFunctionIT.java
  • GeoFilterIT.java
  • MoreLikeThisIT.java
  • FetchSubPhasePluginIT.java

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Compatibility status:

Checks if related components are compatible with change e9ad245

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git]

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@neetikasinghal
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

org.opensearch.search.basic.TransportTwoNodesSearchIT.testQueryThenFetchWithFrom {p0={"search.concurrent_segment_search.enabled":"true"}} - this test is failing, is this flaky can you take a look at it and confirm if it is flaky or is it always failing?
if it is flaky, lets mute the test and create a corresponding issue.

@e-emoto
Copy link
Contributor Author

e-emoto commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

org.opensearch.search.basic.TransportTwoNodesSearchIT.testQueryThenFetchWithFrom {p0={"search.concurrent_segment_search.enabled":"true"}} - this test is failing, is this flaky can you take a look at it and confirm if it is flaky or is it always failing? if it is flaky, lets mute the test and create a corresponding issue.

This test was always failing, I forgot to remove indexRandomForConcurrentSearch from it

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Gradle Check (Jenkins) Run Completed with:

@neetikasinghal
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

org.opensearch.search.basic.TransportTwoNodesSearchIT.testQueryThenFetchWithFrom {p0={"search.concurrent_segment_search.enabled":"true"}} - is this flaky?

@e-emoto e-emoto force-pushed the test-changes branch 2 times, most recently from 60bf49a to bf71dfd Compare November 8, 2023 00:45
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #11119 (e9ad245) into main (3bbc495) will decrease coverage by 0.12%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #11119      +/-   ##
============================================
- Coverage     71.25%   71.13%   -0.12%     
+ Complexity    58820    58781      -39     
============================================
  Files          4883     4883              
  Lines        277139   277139              
  Branches      40284    40284              
============================================
- Hits         197484   197155     -329     
- Misses        63204    63536     +332     
+ Partials      16451    16448       -3     

see 474 files with indirect coverage changes

            Fixed test cases
            Updated fix for TransportTwoNodesSearchIT test cases
            Updated test cases and muted flaky tests
            Move indexRandomForConcurrentSearch call into prepareData
            Remove changes from TransportTwoNodesSearchIT.java until future fix

Signed-off-by: Ethan Emoto <eemoto@amazon.com>
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions github-actions bot added the bug Something isn't working label Nov 8, 2023
@peternied peternied merged commit ff3a6a3 into opensearch-project:main Nov 8, 2023
32 checks passed
@jed326 jed326 added the backport 2.x Backport to 2.x branch label Nov 8, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 8, 2023
Fixed test cases
            Updated fix for TransportTwoNodesSearchIT test cases
            Updated test cases and muted flaky tests
            Move indexRandomForConcurrentSearch call into prepareData
            Remove changes from TransportTwoNodesSearchIT.java until future fix

Signed-off-by: Ethan Emoto <eemoto@amazon.com>
(cherry picked from commit ff3a6a3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peternied pushed a commit that referenced this pull request Nov 8, 2023
Fixed test cases
            Updated fix for TransportTwoNodesSearchIT test cases
            Updated test cases and muted flaky tests
            Move indexRandomForConcurrentSearch call into prepareData
            Remove changes from TransportTwoNodesSearchIT.java until future fix


(cherry picked from commit ff3a6a3)

Signed-off-by: Ethan Emoto <eemoto@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
Fixed test cases
            Updated fix for TransportTwoNodesSearchIT test cases
            Updated test cases and muted flaky tests
            Move indexRandomForConcurrentSearch call into prepareData
            Remove changes from TransportTwoNodesSearchIT.java until future fix

Signed-off-by: Ethan Emoto <eemoto@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Fixed test cases
            Updated fix for TransportTwoNodesSearchIT test cases
            Updated test cases and muted flaky tests
            Move indexRandomForConcurrentSearch call into prepareData
            Remove changes from TransportTwoNodesSearchIT.java until future fix

Signed-off-by: Ethan Emoto <eemoto@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working skip-changelog
Projects
None yet
4 participants