[Sort] Sending missing values in comparator instead sending null

[gashutos]

Description

NumericComparator uses missingValue to determine if to apply BKD based skipping logic in case missingValue is not competitive. If missingValue is competitive, we cant apply this optimization as per the comment.
If we dont pass missing value here, it might hit the corner case like here #9537. We fixed this in Lucene, apache/lucene#12520, but didnt add integ tests here in OpenSearch.

Related Issues

#10998

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[gashutos]

@reta @backslasht @kkmr
This is from this conversation
#11024 (comment)

[github-actions]

Compatibility status:

Checks if related components are compatible with change 9b0af16

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git]

[github-actions]

❕ Gradle check result for 9b0af16: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.http.SearchRestCancellationIT.testAutomaticCancellationDuringFetchPhase

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (8077a26) 71.12% compared to head (9b0af16) 71.17%.
Report is 3 commits behind head on main.

Files	Patch %	Lines
.../index/search/comparators/HalfFloatComparator.java	0.00%	29 Missing ⚠️
...eldcomparator/HalfFloatValuesComparatorSource.java	25.00%	12 Missing ⚠️
.../fieldcomparator/DoubleValuesComparatorSource.java	0.00%	0 Missing and 1 partial ⚠️
...a/fieldcomparator/FloatValuesComparatorSource.java	0.00%	0 Missing and 1 partial ⚠️
...ata/fieldcomparator/IntValuesComparatorSource.java	0.00%	0 Missing and 1 partial ⚠️
...ta/fieldcomparator/LongValuesComparatorSource.java	0.00%	0 Missing and 1 partial ⚠️
...comparator/UnsignedLongValuesComparatorSource.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11196      +/-   ##
============================================
+ Coverage     71.12%   71.17%   +0.04%     
- Complexity    58788    58805      +17     
============================================
  Files          4883     4885       +2     
  Lines        277152   277199      +47     
  Branches      40281    40285       +4     
============================================
+ Hits         197134   197287     +153     
+ Misses        63545    63462      -83     
+ Partials      16473    16450      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dblock]

Looks great, nice and clean.

[dblock]

Backport manually with the proper version number checks in YAML tests?

[gashutos]

Looks great, nice and clean.

Thanks @dblock @backslasht !!
Raised the backport changing the test suported version. (its in 2nd commit)
PR #11250