Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Enabling sort optimization back for half_float with custom comparator… #11197

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

gashutos
Copy link
Contributor

Backport of #11024

opensearch-project#11024)

* Enabling sort optimizatin back for half_float with custom comparators

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Fixing tests

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Adding test for Indecx sort half_float

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Making indexFieldData provate in FloatValuesComparatorSource

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Update server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Chaitanya Gohel <104654647+gashutos@users.noreply.github.com>

* Adding missing value instead null

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Adding more tests for desc order sort

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Update rest-api-spec/src/main/resources/rest-api-spec/test/search/90_search_after.yml

Co-authored-by: Prabhakar Sithanandam <prabhakar.s87@gmail.com>
Signed-off-by: Chaitanya Gohel <104654647+gashutos@users.noreply.github.com>

* Adding tests in case missing values are competitive

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* chanheing newly added test supported version 3.0.0

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Assing missing float tests

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Remove missing value change to be part of another PR

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

---------

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>
Signed-off-by: Chaitanya Gohel <104654647+gashutos@users.noreply.github.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
Co-authored-by: Prabhakar Sithanandam <prabhakar.s87@gmail.com>
@gashutos
Copy link
Contributor Author

@reta

Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 1c697fd

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

✅ Gradle check result for 1c697fd: SUCCESS

@reta reta added backport PRs or issues specific to backporting features or enhancments v2.12.0 Issues and PRs related to version 2.12.0 labels Nov 14, 2023
@reta reta merged commit c2b5587 into opensearch-project:2.x Nov 14, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments v2.12.0 Issues and PRs related to version 2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants