Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Request level coordinator slow logs #11246

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

dzane17
Copy link
Contributor

@dzane17 dzane17 commented Nov 17, 2023

Description

2.x Backport of #10650

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dzane17 dzane17 changed the title Request level coordinator slow logs [Backport 2.x] Request level coordinator slow logs Nov 17, 2023
Signed-off-by: David Zane <davizane@amazon.com>
Copy link
Contributor

❌ Gradle check result for 141f093: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Nov 17, 2023

Compatibility status:

Checks if related components are compatible with change 6a2b197

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/k-nn.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

✅ Gradle check result for 6a2b197: SUCCESS

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (3cc2e54) 70.79% compared to head (6a2b197) 71.02%.

Files Patch % Lines
...opensearch/action/search/SearchRequestSlowLog.java 77.22% 18 Missing and 5 partials ⚠️
...action/search/SearchRequestOperationsListener.java 41.17% 9 Missing and 1 partial ⚠️
...pensearch/action/search/TransportSearchAction.java 37.50% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11246      +/-   ##
============================================
+ Coverage     70.79%   71.02%   +0.22%     
- Complexity    58873    59081     +208     
============================================
  Files          4867     4869       +2     
  Lines        278455   278629     +174     
  Branches      40810    40824      +14     
============================================
+ Hits         197140   197888     +748     
+ Misses        64524    64011     -513     
+ Partials      16791    16730      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh merged commit ceac121 into opensearch-project:2.x Nov 17, 2023
86 checks passed
@dzane17 dzane17 deleted the backport-2.x branch November 17, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants